Allow some lints in .fixed
files when compiling with Compiletest
#88918
Labels
A-compiletest
Area: the compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-dev-tools
Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
See also Manishearth/compiletest-rs#243
Compiletest currently automatically allows all
unused
lints in theCompileFail
andUi
modes. However, this doesn't extend to.fixed
files, which are used inside Clippy. For this reason, we still have a bunch of#[allow()]
attributes in Clippy's tests. It would be nice to have an option to allow lints inside.fixed
compilation tests.In a related discussion (See rust-lang/rust-clippy#7611), we agreed that it would also be cool, if we could be more specific than just allowing all lint's inside the
unused
group. I would suggest adding a new configuration with an enum like this:Clippy uses
compiletest-rs
which is the downstream crate currently managed by @Manishearth. It would be great if this implementation could be done here and then transferred intocompiletest-rs
to keep them kind of in sync.I'm currently quite busy with RL stuff, but would be happy to work on this in about a month, if it would be accepted in rustc's compiletest version. Any feedback regarding the idea is welcome!
cc: @rust-lang/devtools @Manishearth
@rustbot label +A-testsuite +C-enhancement +T-dev-tools
The text was updated successfully, but these errors were encountered: