Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for feature(int_bits_const): <integer>::BITS #76904

Closed
Tracked by #16
m-ou-se opened this issue Sep 19, 2020 · 9 comments · Fixed by #81590
Closed
Tracked by #16

Tracking Issue for feature(int_bits_const): <integer>::BITS #76904

m-ou-se opened this issue Sep 19, 2020 · 9 comments · Fixed by #81590
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Sep 19, 2020 •
edited

Tracking issue for <integer>::BITS as introduced by #76492.

Gated behind feature(int_bits_const).
@m-ou-se m-ou-se added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Sep 19, 2020
@m-ou-se m-ou-se changed the title Tracking Issue for <integer>::BITS Tracking Issue for feature(int_bits_const): <integer>::BITS Sep 19, 2020
@m-ou-se
Copy link
Member Author

m-ou-se commented Sep 19, 2020

@rustbot modify labels: +T-libs

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 19, 2020
@and-arch

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Nov 6, 2020
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 6, 2021

This has been in a few releases, is used in many places in rustc itself, and there's no open questions so far. Time to stabilize?

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jan 6, 2021 •
edited by KodrAus

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 6, 2021
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 21, 2021
@rfcbot
Copy link

rfcbot commented Jan 21, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 21, 2021
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jan 31, 2021
@rfcbot
Copy link

rfcbot commented Jan 31, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 31, 2021
@KodrAus KodrAus mentioned this issue Jan 31, 2021
Merged
@bors bors closed this as completed in 9165676 Feb 1, 2021
@m-ou-se m-ou-se mentioned this issue Feb 2, 2021
Closed
@rfk rfk mentioned this issue Feb 2, 2021
Closed
@m-ou-se
Copy link
Member Author

m-ou-se commented Feb 3, 2021

We agreed in the libs meeting just now to revert stablization, since the breakage is significant throughout the ecosystem, through lexical-core. :( We can stabilize it again once that is solved upstream.

@m-ou-se m-ou-se reopened this Feb 3, 2021
@m-ou-se m-ou-se mentioned this issue Feb 3, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 3, 2021
@Dylan-DPC
Rollup merge of rust-lang#81727 - m-ou-se:unstabilize-bits, r=Mark-Si…
6876aba 
…mulacrum

Revert stabilizing integer::BITS.

We agreed in the libs meeting just now to revert stablization, since the [breakage](rust-lang#81654) is significant throughout the ecosystem, through `lexical-core`.

cc rust-lang#76904

Fixes rust-lang#81654
@astraw astraw mentioned this issue Feb 4, 2021
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this issue Feb 4, 2021
@m-ou-se
Rollup merge of rust-lang#81727 - m-ou-se:unstabilize-bits, r=Mark-Si…
0e2c370 
…mulacrum

Revert stabilizing integer::BITS.

We agreed in the libs meeting just now to revert stablization, since the [breakage](rust-lang#81654) is significant throughout the ecosystem, through `lexical-core`.

cc rust-lang#76904

Fixes rust-lang#81654
m-ou-se added a commit to m-ou-se/rust that referenced this issue Feb 4, 2021
@m-ou-se
Rollup merge of rust-lang#81727 - m-ou-se:unstabilize-bits, r=Mark-Si…
5e4a424 
…mulacrum

Revert stabilizing integer::BITS.

We agreed in the libs meeting just now to revert stablization, since the [breakage](rust-lang#81654) is significant throughout the ecosystem, through `lexical-core`.

cc rust-lang#76904

Fixes rust-lang#81654
m-ou-se added a commit to m-ou-se/rust that referenced this issue Feb 4, 2021
@m-ou-se
Rollup merge of rust-lang#81727 - m-ou-se:unstabilize-bits, r=Mark-Si…
113e27f 
…mulacrum

Revert stabilizing integer::BITS.

We agreed in the libs meeting just now to revert stablization, since the [breakage](rust-lang#81654) is significant throughout the ecosystem, through `lexical-core`.

cc rust-lang#76904

Fixes rust-lang#81654
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 11, 2021
@m-ou-se m-ou-se mentioned this issue Feb 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 25, 2021
@bors
Auto merge of rust-lang#82565 - m-ou-se:ununstabilize-bits, r=kennytm
bba4088 
Revert reverting of stabilizing integer::BITS.

Now that `lexical-core` has an updated version that won't break with this stabilization, let's try to stabilize this again.

See rust-lang#81654 (comment)

Tracking issue with FCP: rust-lang#76904
@joshtriplett
Copy link
Member

Closing this since #82565 has been merged.

@jplatte jplatte mentioned this issue Apr 7, 2021
Open
65 tasks
@adamgemmell adamgemmell mentioned this issue Apr 28, 2021
Merged
@djipko djipko mentioned this issue Mar 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize int_bits_const
7 participants
@joshtriplett @m-ou-se @apiraino @KodrAus @rfcbot @rustbot @and-arch