Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgen changes in 1.39 #65520

Closed
Mark-Simulacrum opened this issue Oct 17, 2019 · 4 comments
Closed

bindgen changes in 1.39 #65520

Mark-Simulacrum opened this issue Oct 17, 2019 · 4 comments
Assignees
@pnkfelix
Labels
E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/gh/theaaf.decklink-rs/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/reg/janet-ll-0.4.1/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/reg/srtp2-sys-2.20.1/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.39-1/beta-2019-09-28/gh/Helkafen.vcf_pwm/log.txt

It's unclear whether this is our fault or bindgen or something else, but the behavior does appear to have changed.

cc #64962
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Oct 17, 2019
@Mark-Simulacrum Mark-Simulacrum added this to the 1.39 milestone Oct 17, 2019
@pnkfelix
Copy link
Member

triage: P-high to get to bottom of what happened.

@ecstatic-morse
Copy link
Contributor

Probably the same as in #65525, but someone should verify this. According to @pcpthm:

Likely due to #64710 exposing bindgen bug rust-lang/rust-bindgen#1627. Updating bindgen fixes the issue.

@pnkfelix pnkfelix added the P-high High priority label Oct 31, 2019
@pnkfelix pnkfelix self-assigned this Oct 31, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Oct 31, 2019 •
edited

(assigning self; beta promotion is happening very soon, since its release is next week)

@Centril Centril removed this from the 1.39 milestone Nov 7, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2019

At this point the release is out, so I'm closing this bug as a task not worth following up on formally. (The point of the task is to try to catch bugs before the release. Once the release is out, we can just let people file them if there are real bugs actually present that are not addressed via cargo update)

@pnkfelix pnkfelix closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pnkfelix @Centril @Mark-Simulacrum @ecstatic-morse