Split non-CAS atomic support off into target_has_atomic_load_store #65214

Amanieu · 2019-10-08T16:13:38Z

This PR implements my proposed changes in #32976 (comment) by removing target_has_atomic = "cas" and splitting target_has_atomic into two separate cfgs:

target_has_atomic = 8/16/32/64/128: This indicates the largest width that the target can atomically CAS (which implies support for all atomic operations).
target_has_atomic_load_store = 8/16/32/64/128: This indicates the largest width that the target can support loading or storing atomically (but may not support CAS).

cc #32976

r? @alexcrichton

Amanieu · 2019-10-08T16:15:36Z

A small note on the code: in some places I do any(target_has_atomic_load_store = "8", target_has_atomic = "8") when target_has_atomic_load_store = "8" should imply both. This is necessary to support stage0 which doesn't have target_has_atomic_load_store.

src/libcore/sync/atomic.rs

Centril · 2019-10-08T16:27:44Z

N.B. I wouldn't mind this as an internal refactoring but I don't think we should expose target_has_atomic or target_has_atomic_load_store to users. Rather, #64797 provides the same facilities.

rust-highfive · 2019-10-08T16:34:14Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-08T16:14:17.8059985Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-08T16:14:17.8254716Z ##[command]git config gc.auto 0
2019-10-08T16:14:17.8338645Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-08T16:14:17.8411264Z ##[command]git config --get-all http.proxy
2019-10-08T16:14:17.8559127Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65214/merge:refs/remotes/pull/65214/merge
---
2019-10-08T16:21:11.9140582Z    Compiling serde_json v1.0.40
2019-10-08T16:21:13.5519239Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-08T16:21:23.9120554Z     Finished release [optimized] target(s) in 1m 22s
2019-10-08T16:21:23.9206981Z tidy check
2019-10-08T16:21:24.5873263Z tidy error: /checkout/src/libcore/sync/atomic.rs:116: line longer than 100 chars
2019-10-08T16:21:24.5873900Z tidy error: /checkout/src/libcore/sync/atomic.rs:117: line longer than 100 chars
2019-10-08T16:21:25.7358083Z some tidy checks failed
2019-10-08T16:21:25.7358305Z 
2019-10-08T16:21:25.7358305Z 
2019-10-08T16:21:25.7359141Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-08T16:21:25.7359251Z 
2019-10-08T16:21:25.7359271Z 
2019-10-08T16:21:25.7414277Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-08T16:21:25.7414367Z Build completed unsuccessfully in 0:01:25
2019-10-08T16:21:25.7414367Z Build completed unsuccessfully in 0:01:25
2019-10-08T16:21:25.7418806Z == clock drift check ==
2019-10-08T16:21:25.7437917Z   local time: Tue Oct  8 16:21:25 UTC 2019
2019-10-08T16:21:25.8399874Z   network time: Tue, 08 Oct 2019 16:21:25 GMT
2019-10-08T16:21:25.8407225Z == end clock drift check ==
2019-10-08T16:21:27.2358213Z ##[error]Bash exited with code '1'.
2019-10-08T16:21:27.2397885Z ##[section]Starting: Checkout
2019-10-08T16:21:27.2399370Z ==============================================================================
2019-10-08T16:21:27.2399427Z Task         : Get sources
2019-10-08T16:21:27.2399462Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-08T19:30:40Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-08T18:59:22.8233574Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-08T18:59:23.3709845Z ##[command]git config gc.auto 0
2019-10-08T18:59:23.3715205Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-08T18:59:23.3725521Z ##[command]git config --get-all http.proxy
2019-10-08T18:59:23.3766880Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65214/merge:refs/remotes/pull/65214/merge
---
2019-10-08T19:26:10.3429064Z    Compiling rustc_codegen_ssa v0.0.0 (/checkout/src/librustc_codegen_ssa)
2019-10-08T19:27:11.3484862Z    Compiling rustc_save_analysis v0.0.0 (/checkout/src/librustc_save_analysis)
2019-10-08T19:27:59.1944740Z    Compiling rustc_plugin v0.0.0 (/checkout/src/librustc_plugin/deprecated)
2019-10-08T19:30:18.1180853Z    Compiling rustc-main v0.0.0 (/checkout/src/rustc)
2019-10-08T19:30:18.3678809Z error: linking with `cc` failed: exit code: 1
2019-10-08T19:30:18.3679522Z   |
2019-10-08T19:30:18.3682045Z   = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_binary-ff7ef2a49a698d0a.rustc_binary.b9c6s0cq-cgu.0.rcgu.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_binary-ff7ef2a49a698d0a.rustc_binary.b9c6s0cq-cgu.1.rcgu.o" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_binary-ff7ef2a49a698d0a" "-Wl,--gc-sections" "-pie" "-Wl,-zrelro" "-Wl,-znow" "-Wl,-O1" "-nodefaultlibs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-c5a99509fe2f0f44/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-cde8801c1a0250cb/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps" "-lrustc_driver-dc46f81f35f7db72" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-ltest-4441714d48a81082" "-Wl,--start-group" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-lstd-539b46668317e4b1" "-Wl,--end-group" "-Wl,-Bstatic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-58f6922a5d63f76a.rlib" "-Wl,-Bdynamic" "-lutil" "-lutil" "-ldl" "-lrt" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lutil" "-lutil" "-Wl,-rpath,$ORIGIN/../lib"
2019-10-08T19:30:18.3682846Z   = note: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-539b46668317e4b1.so: undefined reference to `__sync_val_compare_and_swap_16'
2019-10-08T19:30:18.3683092Z           collect2: error: ld returned 1 exit status
2019-10-08T19:30:18.3683360Z 
2019-10-08T19:30:18.3753489Z error: aborting due to previous error
2019-10-08T19:30:18.3753661Z 
2019-10-08T19:30:18.3931868Z error: could not compile `rustc-main`.
---
2019-10-08T19:30:18.4057326Z == clock drift check ==
2019-10-08T19:30:18.4079146Z   local time: Tue Oct  8 19:30:18 UTC 2019
2019-10-08T19:30:18.5013578Z   network time: Tue, 08 Oct 2019 19:30:18 GMT
2019-10-08T19:30:18.5015332Z == end clock drift check ==
2019-10-08T19:30:21.0151165Z ##[error]Bash exited with code '1'.
2019-10-08T19:30:21.0199463Z ##[section]Starting: Checkout
2019-10-08T19:30:21.0201615Z ==============================================================================
2019-10-08T19:30:21.0201666Z Task         : Get sources
2019-10-08T19:30:21.0201728Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-10-09T17:02:28Z

r=me on the code changes here, although I'm travleing this week so I'm not abreast of the conversation happening in the thread. If it's reached consensus this is the way to go feel free to send it through bors! Otherwise I'll check in when I'm back next week to catch up on the thread

Amanieu · 2019-10-13T00:03:55Z

@bors r=alexcrichton

bors · 2019-10-13T00:03:57Z

📌 Commit dfe76a1 has been approved by alexcrichton

bors · 2019-10-13T15:17:25Z

⌛ Testing commit dfe76a1 with merge e45bc382e7333fd3fcc3da15d147faaf89062ea7...

@alexcrichton

Split non-CAS atomic support off into target_has_atomic_load_store This PR implements my proposed changes in rust-lang#32976 (comment) by removing `target_has_atomic = "cas"` and splitting `target_has_atomic` into two separate `cfg`s: * `target_has_atomic = 8/16/32/64/128`: This indicates the largest width that the target can atomically CAS (which implies support for all atomic operations). * ` target_has_atomic_load_store = 8/16/32/64/128`: This indicates the largest width that the target can support loading or storing atomically (but may not support CAS). cc rust-lang#32976 r? @alexcrichton

Centril · 2019-10-13T15:20:14Z

@bors retry rolled up.

bors · 2019-10-13T17:13:10Z

⌛ Testing commit dfe76a1 with merge 0c36b2a3c2faf937a78f91b104515ff4b79bd6a1...

@alexcrichton

Split non-CAS atomic support off into target_has_atomic_load_store This PR implements my proposed changes in rust-lang#32976 (comment) by removing `target_has_atomic = "cas"` and splitting `target_has_atomic` into two separate `cfg`s: * `target_has_atomic = 8/16/32/64/128`: This indicates the largest width that the target can atomically CAS (which implies support for all atomic operations). * ` target_has_atomic_load_store = 8/16/32/64/128`: This indicates the largest width that the target can support loading or storing atomically (but may not support CAS). cc rust-lang#32976 r? @alexcrichton

Centril · 2019-10-13T17:18:50Z

@bors retry rolled up.

@ghost

Rollup of 10 pull requests Successful merges: - #65214 (Split non-CAS atomic support off into target_has_atomic_load_store) - #65246 (vxWorks: implement get_path() and get_mode() for File fmt::Debug) - #65312 (improve performance of signed saturating_mul) - #65336 (Fix typo in task::Waker) - #65346 (nounwind tests and cleanup) - #65347 (Fix #[unwind(abort)] with Rust ABI) - #65366 (Implement Error::source on IntoStringError + Remove superfluous cause impls) - #65369 (Don't discard value names when using address or memory sanitizer) - #65370 (Add `dyn` to `Any` documentation) - #65373 (Fix typo in docs for `Rc`) Failed merges: r? @ghost

428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Co-authored-by: Taiki Endo <te316e89@gmail.com>

428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <te316e89@gmail.com>

428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <te316e89@gmail.com>

mmalinin · 2019-10-21T10:33:51Z

src/libstd/panic.rs

 #[stable(feature = "unwind_safe_atomic_refs", since = "1.14.0")]
 impl RefUnwindSafe for atomic::AtomicUsize {}
-#[cfg(target_has_atomic = "8")]
+#[cfg(target_hastarget_has_atomic_load_store_atomic = "8")]


copypaste error?

Oops #65663

Fix typo from rust-lang#65214

@ghost

Rollup of 7 pull requests Successful merges: - #62330 (Change untagged_unions to not allow union fields with drop) - #65092 (make is_power_of_two a const function) - #65621 (miri: add write_bytes method to Memory doing bounds-checks and supporting iterators) - #65647 (Remove unnecessary trait bounds and derivations) - #65653 (keep the root dir clean from debugging) - #65660 (Rename `ConstValue::Infer(InferConst::Canonical(..))` to `ConstValue::Bound(..)`) - #65663 (Fix typo from #65214) Failed merges: r? @ghost

16: Update crossbeam-epoch requirement from 0.7.0 to 0.8.0 r=bossmc a=dependabot-preview[bot] Updates the requirements on [crossbeam-epoch](https://github.com/crossbeam-rs/crossbeam) to permit the latest version. <details> <summary>Changelog</summary> *Sourced from [crossbeam-epoch's changelog](https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md).* > # Version 0.7.3 > > - Fix breakage with nightly feature due to [rust-lang/rust#65214](https://github-redirect.dependabot.com/rust-lang/rust/issues/65214). > - Bump `crossbeam-channel` to `0.4`. > - Bump `crossbeam-epoch` to `0.8`. > - Bump `crossbeam-queue` to `0.2`. > - Bump `crossbeam-utils` to `0.7`. > > # Version 0.7.2 > > - Bump `crossbeam-channel` to `0.3.9`. > - Bump `crossbeam-epoch` to `0.7.2`. > - Bump `crossbeam-utils` to `0.6.6`. > > # Version 0.7.1 > > - Bump `crossbeam-utils` to `0.6.5`. > > # Version 0.7.0 > > - Remove `ArcCell`, `MsQueue`, and `TreiberStack`. > - Change the interface of `ShardedLock` to match `RwLock`. > - Add `SegQueue::len()`. > - Rename `SegQueue::try_pop()` to `SegQueue::pop()`. > - Change the return type of `SegQueue::pop()` to `Result`. > - Introduce `ArrayQueue`. > - Update dependencies. > > # Version 0.6.0 > > - Update dependencies. > > # Version 0.5.0 > > - Update `crossbeam-channel` to 0.3. > - Update `crossbeam-utils` to 0.6. > - Add `AtomicCell`, `SharedLock`, and `WaitGroup`. > > # Version 0.4.1 > > - Fix a double-free bug in `MsQueue` and `SegQueue`. > > # Version 0.4 > > - Switch to the new implementation of epoch-based reclamation in > [`crossbeam-epoch`](https://github.com/crossbeam-rs/crossbeam-epoch), fixing numerous bugs in the > old implementation. Its API is changed in a backward-incompatible way. > - Switch to the new implementation of `CachePadded` and scoped thread in > [`crossbeam-utils`](https://github.com/crossbeam-rs/crossbeam-utils). The scoped thread API is > changed in a backward-incompatible way. ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`28ad2b7`](crossbeam-rs/crossbeam@28ad2b7) Update versions in readmes - [`c98fea1`](crossbeam-rs/crossbeam@c98fea1) Merge [#444](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/444) - [`d953f49`](crossbeam-rs/crossbeam@d953f49) Add compatibility section to readme - [`c76f145`](crossbeam-rs/crossbeam@c76f145) Prepare for the next release - [`99762ee`](crossbeam-rs/crossbeam@99762ee) Merge [#442](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/442) - [`ebb6b5f`](crossbeam-rs/crossbeam@ebb6b5f) Do not perform superfluous bounds checks on drop - [`d2ab7a5`](crossbeam-rs/crossbeam@d2ab7a5) Update LICENSE-APACHE - [`f54db88`](crossbeam-rs/crossbeam@f54db88) Merge [#437](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/437) - [`caa52c4`](crossbeam-rs/crossbeam@caa52c4) Merge [#436](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/436) - [`af68803`](crossbeam-rs/crossbeam@af68803) Merge [#438](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/438) - Additional commits viewable in [compare view](crossbeam-rs/crossbeam@crossbeam-epoch-0.7.0...crossbeam-epoch-0.8.0) </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

155: Bump crossbeam-channel from 0.3.9 to 0.4.0 r=pitkley a=dependabot-preview[bot] [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.3.9 to 0.4.0. <details> <summary>Changelog</summary> *Sourced from [crossbeam-channel's changelog](https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md).* > # Version 0.7.3 > > - Fix breakage with nightly feature due to [rust-lang/rust#65214](https://github-redirect.dependabot.com/rust-lang/rust/issues/65214). > - Bump `crossbeam-channel` to `0.4`. > - Bump `crossbeam-epoch` to `0.8`. > - Bump `crossbeam-queue` to `0.2`. > - Bump `crossbeam-utils` to `0.7`. > > # Version 0.7.2 > > - Bump `crossbeam-channel` to `0.3.9`. > - Bump `crossbeam-epoch` to `0.7.2`. > - Bump `crossbeam-utils` to `0.6.6`. > > # Version 0.7.1 > > - Bump `crossbeam-utils` to `0.6.5`. > > # Version 0.7.0 > > - Remove `ArcCell`, `MsQueue`, and `TreiberStack`. > - Change the interface of `ShardedLock` to match `RwLock`. > - Add `SegQueue::len()`. > - Rename `SegQueue::try_pop()` to `SegQueue::pop()`. > - Change the return type of `SegQueue::pop()` to `Result`. > - Introduce `ArrayQueue`. > - Update dependencies. > > # Version 0.6.0 > > - Update dependencies. > > # Version 0.5.0 > > - Update `crossbeam-channel` to 0.3. > - Update `crossbeam-utils` to 0.6. > - Add `AtomicCell`, `SharedLock`, and `WaitGroup`. > > # Version 0.4.1 > > - Fix a double-free bug in `MsQueue` and `SegQueue`. > > # Version 0.4 > > - Switch to the new implementation of epoch-based reclamation in > [`crossbeam-epoch`](https://github.com/crossbeam-rs/crossbeam-epoch), fixing numerous bugs in the > old implementation. Its API is changed in a backward-incompatible way. > - Switch to the new implementation of `CachePadded` and scoped thread in > [`crossbeam-utils`](https://github.com/crossbeam-rs/crossbeam-utils). The scoped thread API is > changed in a backward-incompatible way. ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`28ad2b7`](crossbeam-rs/crossbeam@28ad2b7) Update versions in readmes - [`c98fea1`](crossbeam-rs/crossbeam@c98fea1) Merge [#444](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/444) - [`d953f49`](crossbeam-rs/crossbeam@d953f49) Add compatibility section to readme - [`c76f145`](crossbeam-rs/crossbeam@c76f145) Prepare for the next release - [`99762ee`](crossbeam-rs/crossbeam@99762ee) Merge [#442](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/442) - [`ebb6b5f`](crossbeam-rs/crossbeam@ebb6b5f) Do not perform superfluous bounds checks on drop - [`d2ab7a5`](crossbeam-rs/crossbeam@d2ab7a5) Update LICENSE-APACHE - [`f54db88`](crossbeam-rs/crossbeam@f54db88) Merge [#437](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/437) - [`caa52c4`](crossbeam-rs/crossbeam@caa52c4) Merge [#436](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/436) - [`af68803`](crossbeam-rs/crossbeam@af68803) Merge [#438](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/438) - Additional commits viewable in [compare view](crossbeam-rs/crossbeam@crossbeam-channel-0.3.9...crossbeam-channel-0.4.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=crossbeam-channel&package-manager=cargo&previous-version=0.3.9&new-version=0.4.0)](https://dependabot.com/compatibility-score.html?dependency-name=crossbeam-channel&package-manager=cargo&previous-version=0.3.9&new-version=0.4.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

155: Bump crossbeam-channel from 0.3.9 to 0.4.0 r=pitkley a=dependabot-preview[bot] Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.3.9 to 0.4.0. <details> <summary>Changelog</summary> *Sourced from [crossbeam-channel's changelog](https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md).* > # Version 0.7.3 > > - Fix breakage with nightly feature due to [rust-lang/rust#65214](https://github-redirect.dependabot.com/rust-lang/rust/issues/65214). > - Bump `crossbeam-channel` to `0.4`. > - Bump `crossbeam-epoch` to `0.8`. > - Bump `crossbeam-queue` to `0.2`. > - Bump `crossbeam-utils` to `0.7`. > > # Version 0.7.2 > > - Bump `crossbeam-channel` to `0.3.9`. > - Bump `crossbeam-epoch` to `0.7.2`. > - Bump `crossbeam-utils` to `0.6.6`. > > # Version 0.7.1 > > - Bump `crossbeam-utils` to `0.6.5`. > > # Version 0.7.0 > > - Remove `ArcCell`, `MsQueue`, and `TreiberStack`. > - Change the interface of `ShardedLock` to match `RwLock`. > - Add `SegQueue::len()`. > - Rename `SegQueue::try_pop()` to `SegQueue::pop()`. > - Change the return type of `SegQueue::pop()` to `Result`. > - Introduce `ArrayQueue`. > - Update dependencies. > > # Version 0.6.0 > > - Update dependencies. > > # Version 0.5.0 > > - Update `crossbeam-channel` to 0.3. > - Update `crossbeam-utils` to 0.6. > - Add `AtomicCell`, `SharedLock`, and `WaitGroup`. > > # Version 0.4.1 > > - Fix a double-free bug in `MsQueue` and `SegQueue`. > > # Version 0.4 > > - Switch to the new implementation of epoch-based reclamation in > [`crossbeam-epoch`](https://github.com/crossbeam-rs/crossbeam-epoch), fixing numerous bugs in the > old implementation. Its API is changed in a backward-incompatible way. > - Switch to the new implementation of `CachePadded` and scoped thread in > [`crossbeam-utils`](https://github.com/crossbeam-rs/crossbeam-utils). The scoped thread API is > changed in a backward-incompatible way. ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`28ad2b7`](crossbeam-rs/crossbeam@28ad2b7) Update versions in readmes - [`c98fea1`](crossbeam-rs/crossbeam@c98fea1) Merge [#444](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/444) - [`d953f49`](crossbeam-rs/crossbeam@d953f49) Add compatibility section to readme - [`c76f145`](crossbeam-rs/crossbeam@c76f145) Prepare for the next release - [`99762ee`](crossbeam-rs/crossbeam@99762ee) Merge [#442](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/442) - [`ebb6b5f`](crossbeam-rs/crossbeam@ebb6b5f) Do not perform superfluous bounds checks on drop - [`d2ab7a5`](crossbeam-rs/crossbeam@d2ab7a5) Update LICENSE-APACHE - [`f54db88`](crossbeam-rs/crossbeam@f54db88) Merge [#437](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/437) - [`caa52c4`](crossbeam-rs/crossbeam@caa52c4) Merge [#436](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/436) - [`af68803`](crossbeam-rs/crossbeam@af68803) Merge [#438](https://github-redirect.dependabot.com/crossbeam-rs/crossbeam/issues/438) - Additional commits viewable in [compare view](crossbeam-rs/crossbeam@crossbeam-channel-0.3.9...crossbeam-channel-0.4.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=crossbeam-channel&package-manager=cargo&previous-version=0.3.9&new-version=0.4.0)](https://dependabot.com/compatibility-score.html?dependency-name=crossbeam-channel&package-manager=cargo&previous-version=0.3.9&new-version=0.4.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Profiler: reenable atomics after rust-lang#65214

428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <te316e89@gmail.com>

rust-highfive assigned alexcrichton Oct 8, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2019

Amanieu mentioned this pull request Oct 8, 2019

Tracking issue for #[cfg(target_has_atomic = ...)] #32976

Closed

Centril reviewed Oct 8, 2019

View reviewed changes

src/libcore/sync/atomic.rs Outdated Show resolved Hide resolved

Amanieu force-pushed the cfg_atomic branch 2 times, most recently from 1f8b717 to e46eb11 Compare October 8, 2019 18:58

Split non-CAS atomic support off into target_has_atomic_load_store

dfe76a1

Amanieu force-pushed the cfg_atomic branch from e46eb11 to dfe76a1 Compare October 8, 2019 19:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2019

Centril mentioned this pull request Oct 13, 2019

Rollup of 12 pull requests #65382

Closed

Centril mentioned this pull request Oct 13, 2019

Rollup of 10 pull requests #65388

Merged

bors merged commit dfe76a1 into rust-lang:master Oct 13, 2019

sinkuu mentioned this pull request Oct 15, 2019

Fail to build rustfmt since rustc 1.40.0-nightly (c27f7568b 2019-10-13) #65424

Closed

taiki-e mentioned this pull request Oct 15, 2019

Fix build failure on nightly and the minimum version crossbeam-rs/crossbeam#428

Merged

taiki-e mentioned this pull request Oct 16, 2019

Fix breakage with cfg-target-has-atomic feature rust-lang/futures-rs#1914

Merged

novacrazy mentioned this pull request Oct 17, 2019

Crossbeam appears broken on latest nightly crossbeam-rs/crossbeam#434

Closed

mmalinin reviewed Oct 21, 2019

View reviewed changes

Amanieu added a commit to Amanieu/rust that referenced this pull request Oct 21, 2019

Fix typo from rust-lang#65214

3de7698

Centril added a commit to Centril/rust that referenced this pull request Oct 21, 2019

Rollup merge of rust-lang#65663 - Amanieu:typo, r=varkor

644228d

Fix typo from rust-lang#65214

Centril mentioned this pull request Oct 21, 2019

Rollup of 7 pull requests #65670

Closed

Centril added a commit to Centril/rust that referenced this pull request Oct 21, 2019

Rollup merge of rust-lang#65663 - Amanieu:typo, r=varkor

56756c2

Fix typo from rust-lang#65214

Centril mentioned this pull request Oct 21, 2019

Rollup of 7 pull requests #65671

Merged

dekellum mentioned this pull request Nov 22, 2019

Prune duplicate crossbeam dependencies tokio-rs/tokio#1795

Merged

mati865 added a commit to mati865/rust that referenced this pull request Aug 23, 2020

Profiler: reenable atomics after rust-lang#65214

1a9def1

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2020

Auto merge of rust-lang#75838 - mati865:profiler-atomics, r=Amanieu

5890563

Profiler: reenable atomics after rust-lang#65214

KodrAus mentioned this pull request Sep 20, 2020

Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut. #76965

Merged

This was referenced Mar 12, 2021

Update crossbeam-epoch requirement from 0.8 to 0.9 wingertge/artemis#12

Closed

Update crossbeam-utils requirement from 0.6 to 0.8 JackNewman12/NetHex#7

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split non-CAS atomic support off into target_has_atomic_load_store #65214

Split non-CAS atomic support off into target_has_atomic_load_store #65214

Amanieu commented Oct 8, 2019

Amanieu commented Oct 8, 2019

Centril commented Oct 8, 2019

rust-highfive commented Oct 8, 2019

rust-highfive commented Oct 8, 2019

alexcrichton commented Oct 9, 2019

Amanieu commented Oct 13, 2019

bors commented Oct 13, 2019

bors commented Oct 13, 2019

Centril commented Oct 13, 2019

bors commented Oct 13, 2019

Centril commented Oct 13, 2019

mmalinin Oct 21, 2019

Amanieu Oct 21, 2019

Split non-CAS atomic support off into target_has_atomic_load_store #65214

Split non-CAS atomic support off into target_has_atomic_load_store #65214

Conversation

Amanieu commented Oct 8, 2019

Amanieu commented Oct 8, 2019

Centril commented Oct 8, 2019

rust-highfive commented Oct 8, 2019

rust-highfive commented Oct 8, 2019

alexcrichton commented Oct 9, 2019

Amanieu commented Oct 13, 2019

bors commented Oct 13, 2019

bors commented Oct 13, 2019

Centril commented Oct 13, 2019

bors commented Oct 13, 2019

Centril commented Oct 13, 2019

mmalinin Oct 21, 2019

Choose a reason for hiding this comment

Amanieu Oct 21, 2019

Choose a reason for hiding this comment