Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case-insensitive regexes were useful #2760

Open
Dr-Emann opened this issue Feb 13, 2024 · 0 comments
Open

Case-insensitive regexes were useful #2760

Dr-Emann opened this issue Feb 13, 2024 · 0 comments

Comments

@Dr-Emann
Copy link

Dr-Emann commented Feb 13, 2024 •
edited

I think case insensitivity (unicode-case) was useful:

--allowlist-item '(?i)(aaa|bbb).*' used to work for e.g. AAA_CONST, and bbb_func()

Now it (silently 馃槻) matches nothing.

As a workaround, it looks like for my case I can use --allowlist-item '(?i-u:aaa|bbb).*', which turns on case insensitivity, and turns off unicode matching for my literal prefixes.

Originally posted by @Dr-Emann in #2702 (comment)
Dr-Emann added a commit to Dr-Emann/croaring-rs that referenced this issue Feb 13, 2024
@Dr-Emann
Fix bindgen not finding anything
1fae467 
See [bindgen issue][1], tl;dr, they deactivated unicode case insensitivity for
regexes, which makes us do this slightly strange version

[1]: rust-lang/rust-bindgen#2760
Dr-Emann added a commit to Dr-Emann/croaring-rs that referenced this issue Feb 13, 2024
@Dr-Emann
Fix bindgen not finding anything
dd8de34 
See [bindgen issue][1], tl;dr, they deactivated unicode case insensitivity for
regexes, which makes us do this slightly strange version

[1]: rust-lang/rust-bindgen#2760
Dr-Emann added a commit to Dr-Emann/croaring-rs that referenced this issue Feb 13, 2024
@Dr-Emann
Fix bindgen not finding anything
476c829 
See [bindgen issue][1], tl;dr, they deactivated unicode case insensitivity for
regexes, which makes us do this slightly strange version

[1]: rust-lang/rust-bindgen#2760
@Dr-Emann Dr-Emann mentioned this issue Feb 13, 2024
Merged
Dr-Emann added a commit to RoaringBitmap/croaring-rs that referenced this issue Feb 19, 2024
@Dr-Emann
Fix bindgen not finding anything
a61067e 
See [bindgen issue][1], tl;dr, they deactivated unicode case insensitivity for
regexes, which makes us do this slightly strange version

[1]: rust-lang/rust-bindgen#2760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dr-Emann