Generate #[must_use] on functions returing a typedef to a must-use-type
#2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #[must_use] attribute does not need to be generated for functions returning a type that already has #[must_use] on it. Stop generating the extraneous attribute to restore previous behavior.
emilio
approved these changes
Jun 5, 2022
aatifsyed
pushed a commit
to aatifsyed/rust-bindgen
that referenced
this pull request
Sep 22, 2022
LoganBarnett
pushed a commit
to LoganBarnett/rust-bindgen
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2186
I added a test case that uses aliased builtin types and structs, as well as some extra checks just to ensure the underlying types aren't being marked
#[must_use].This is my first contribution to bindgen so please let me know if I should change anything re: code style, naming conventions, etc.! I did my best to follow the existing conventions that I found.