Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BindgenError and Change generate to return the error #2125

Merged
merged 10 commits into from Dec 29, 2021
Merged

Add BindgenError and Change generate to return the error #2125

merged 10 commits into from Dec 29, 2021

Conversation

MikuroXina
Copy link
Contributor

Resolves #2124.

madsmtm
madsmtm reviewed Dec 4, 2021
View reviewed changes
src/lib.rs Show resolved Hide resolved
madsmtm
madsmtm reviewed Dec 5, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
madsmtm
madsmtm approved these changes Dec 8, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
madsmtm
madsmtm reviewed Dec 8, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
madsmtm
madsmtm approved these changes Dec 9, 2021
View reviewed changes
Copy link

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, nice work! (I'm not a maintainer of the project, so I can't give the final green light, sorry!)

@MikuroXina MikuroXina changed the title Add BindgenError and Deprecate generate Add BindgenError and Change generate to return the error Dec 23, 2021
emilio
emilio approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to make the error fully opaque or so but anyways this looks like an improvement to me, thank you!

Sorry for the lag getting to this.

@emilio emilio merged commit e24afad into rust-lang:master Dec 29, 2021
@MikuroXina MikuroXina deleted the feat/#2124 branch December 30, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builder::generate should not return Result<_, ()>
4 participants
@MikuroXina @emilio @madsmtm @highfive