Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a C naming option #2045

Closed
wants to merge 1 commit into from
Closed

Add a C naming option #2045

wants to merge 1 commit into from

Conversation

Bobo1239
Copy link
Contributor

Implements this idea since I've needed bindings for libplacebo which has recently switched to typedefing its main types in haasn/libplacebo@dd755a0 which bindgen can't generate valid bindings for. The problematic typedefs have this structure:

typedef const struct a {
    int a;
} *a;

Not sure at all about the implementation and whether this is actually desired... But at least seems to work well when generating bindings for libplacebo.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks sensible to me, thanks. Quite unfortunate if you ask me but... :)

@emilio emilio closed this in 4943058 Apr 30, 2021
@emilio
Copy link
Contributor

emilio commented Apr 30, 2021

There was a minor formatting issue with CI, so I fixed it up and pushed manually. Thanks!

LoganBarnett pushed a commit to LoganBarnett/rust-bindgen that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants