Don't generate bindings for deleted member functions #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang#2043 for details.
|
|
emilio
approved these changes
Apr 30, 2021
| @@ -597,6 +597,10 @@ impl ClangSubItemParser for Function { | |||
| return Err(ParseError::Continue); | |||
| } | |||
|
|
|||
| if cursor.is_deleted_function() { | |||
| return Err(ParseError::Continue); | |||
| } | |||
There was a problem hiding this comment.
It might be worth to shuffle the logic a bit to do less work in the common case, something like:
if cursor.is_inlined_function() {
if !context.options().generate_inline_functions {
return Err(..);
}
if cursor.is_deleted_function() {
return Err(..);
}
}
|
CI looks green except for rustfmt, so will merge with that fixed and my nit addressed. Thanks! |
|
Awesome! Was about to push fixes, but you were faster than me. Thanks for fixing those two nits for me! |
LoganBarnett
pushed a commit
to LoganBarnett/rust-bindgen
that referenced
this pull request
Dec 2, 2023
Closes rust-lang#2044 Fixes rust-lang#2043 See rust-lang#2043 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2043 for details.