Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist_recursively deleted without deprecation or changelog note #2022

Closed
thomwiggers opened this issue Apr 5, 2021 · 2 comments
Closed

Comments

@thomwiggers
Copy link

thomwiggers commented Apr 5, 2021

Bindgen Invocation

bindgen::Builder::default()
    .whitelist_recursively()

Actual Results

 error[E0599]: no method named `whitelist_recursively` found for struct `bindgen::Builder` in the current scope
Error:   --> oqs-sys/build.rs:23:10
   |
23 |         .whitelist_recursively(false)
   |          ^^^^^^^^^^^^^^^^^^^^^ help: there is an associated function with a similar name: `allowlist_recursively`

Expected Results

One of:

  • Deprecation warning, compilation still succeeds, note in the changelog under "deprecated"
  • Note of deletion in the changelog — this is missing
@thomwiggers thomwiggers changed the title whitelist_recursively deleted without deprecation whitelist_recursively deleted without deprecation or changelog note Apr 5, 2021
@emilio
Copy link
Contributor

emilio commented Apr 6, 2021

Yeah, this seems like an oversight in #1990, cc @hlopko. Will fix ASAP, thanks for reporting.

@emilio emilio closed this as completed in af2c8b8 Apr 6, 2021
@emilio
Copy link
Contributor

emilio commented Apr 6, 2021

Thanks for reporting, and thanks @hlopko for #1990 again (sorry, I just noticed the comment above looked a lot like "hey look you broke this", but was intended to be more on the lines of "hey, no need for you to fix this, I'll take care of it" :)).

LoganBarnett pushed a commit to LoganBarnett/rust-bindgen that referenced this issue Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants