Add option to translate enum integer types to native Rust integer types #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
force-pushed
the
jb/enum-translate-type
branch
2 times, most recently
from
1e6de44
to
1fc3aca
Compare
jethrogb
commented
Mar 10, 2021
| @@ -2543,6 +2543,8 @@ impl<'a> EnumBuilder<'a> { | |||
| }, | |||
|
|
|||
| EnumVariation::Rust { .. } => { | |||
| // `repr` is guaranteed to be Rustified in Enum::codegen | |||
| attrs.insert(0, quote! { #[repr( #repr )] }); | |||
There was a problem hiding this comment.
Using insert instead of push to avoid having to update lots of test cases.
jethrogb
force-pushed
the
jb/enum-translate-type
branch
from
1fc3aca
to
73be2a9
Compare
jethrogb
commented
Mar 10, 2021
|
☔ The latest upstream changes (presumably 7286c81) made this pull request unmergeable. Please resolve the merge conflicts. |
jethrogb
force-pushed
the
jb/enum-translate-type
branch
from
73be2a9
to
b9dbb39
Compare
jethrogb
force-pushed
the
jb/enum-translate-type
branch
from
b9dbb39
to
3e406ec
Compare
1 task
bors bot
added a commit
to fortanix/rust-mbedtls
that referenced
this pull request
Apr 6, 2021
152: Update bindgen r=raoulstrackx a=jethrogb I took some time this week to make the necessary bindgen changes (rust-lang/rust-bindgen#2004 rust-lang/rust-bindgen#2006 rust-lang/rust-bindgen#2007). This PR updates the bindgen build to use that. Breaking changes: * unnamed types are renamed * C-unions are now actual unions * [x] the field accessor functions that used to exist are easy enough to add back * bitfields are done differently now * some fn-ptrs are now unsafe * some fns and fn-ptrs now take const pointers as arguments * havege.c and timing.c are now not compiled on non-unix platforms, i.e. SGX (probably wasn't working properly anyway) Fixes #5 #14 #61 #72 #88 #121 Co-authored-by: Jethro Beekman <jethro@fortanix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430