Docstrings missing for constant values in C++ headers.

[achary]

Input C/C++ Header

// test.hpp

#pragma once

/// This is a constant that has a docstring
///
/// And expected be be found in generated bindings code too.
const int FOO = 1;

/// This is a constant that has a docstring
///
/// And expected be be found in generated bindings code too.
struct Bar
{
    int baz;
};

Bindgen Invocation

// in build.rs 

    let bindings = bindgen::Builder::default()
        .header("test.hpp")
        .layout_tests(false)
        .generate_comments(true)
        .generate()
        .expect("Unable to generate bindings");

    bindings
        .write_to_file(out_path.join("test.rs"))
        .expect("Couldn't write bindings!");

Actual Results

/* automatically generated by rust-bindgen 0.57.0 */

pub const FOO: ::std::os::raw::c_int = 1;
#[doc = " This is a constant that has a docstring"]
#[doc = ""]
#[doc = " And expected be be found in generated bindings code too."]
#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct Bar {
    pub baz: ::std::os::raw::c_int,
}

Expected Results

Markdown docstring for the const FOO should be present in the output *.rs file as well.

[emilio]

impl CodeGenerator for Var doesn't look at item.comment(), and it probably should, should be trivial to fix :)

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in Matrix.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[emilio]

this was fixed in #2027, thanks!