Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fields as non-pub if they would be access restricted in C++. #1968

Merged
merged 1 commit into from Jan 29, 2021

Conversation

SilensAngelusNex
Copy link
Contributor

Fixes #1926

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

src/ir/comp.rs Outdated Show resolved Hide resolved
src/ir/comp.rs Outdated Show resolved Hide resolved
tests/expectations/tests/class_nested.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Can you squash your commits and remove the stray println? Thanks!

src/options.rs Outdated Show resolved Hide resolved
@SilensAngelusNex
Copy link
Contributor Author

This isn't waiting on anything more from me is it?

@emilio
Copy link
Contributor

emilio commented Jan 29, 2021

(No, not waiting for you sorry, was just swamped with exams and work)

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good :)

@emilio emilio merged commit e0f06c7 into rust-lang:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private C++ members generate bindings that are public.
3 participants