Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .with_rustfmt("rustfmt") if the which-rustfmt feature is disabled? #1628

Closed
heidezomp opened this issue Sep 24, 2019 · 2 comments
Closed

Comments

@heidezomp
Copy link
Contributor

I was very pleased to see that #1615 reduces the number of dependencies used by bindgen. However, now my bindings don't get formatted unless I add .with_rustfmt("rustfmt") to the builder options. Since the which dependency resolves a relative path to an absolute path, and adding the .with_rustfmt("rustfmt") option has the same effect but with the shell doing the resolving, would this be a reasonable fallback to add in case the which-rustfmt feature is disabled?

@emilio
Copy link
Contributor

emilio commented Sep 26, 2019

Perhaps, that would make sense to me.

@heidezomp
Copy link
Contributor Author

Thanks for the quick reply and merge! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants