Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir: Make Ord and PartialOrd implementations agree. #1627

Merged
merged 1 commit into from Sep 23, 2019

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Sep 23, 2019

See rust-lang/rust#64710.

Bogus implementations were introduced in 230545e, d3e39dc, and 379bb16.

@emilio emilio merged commit 9696bc1 into rust-lang:master Sep 23, 2019
@emilio emilio deleted the ord-shenanigans branch September 23, 2019 16:33
SimonSapin added a commit to servo/mozjs that referenced this pull request Sep 24, 2019
SimonSapin added a commit to servo/mozjs that referenced this pull request Sep 24, 2019
bors-servo pushed a commit to servo/mozjs that referenced this pull request Sep 24, 2019
Update rust-bindgen to 0.51

… to pick up rust-lang/rust-bindgen#1627

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/201)
<!-- Reviewable:end -->
pcpthm added a commit to pcpthm/libffi-sys-rs that referenced this pull request Oct 19, 2019
A bug <rust-lang/rust-bindgen#1627> causes compilation failure in nightly compiler.
pcpthm added a commit to pcpthm/libsamplerate-sys that referenced this pull request Oct 19, 2019
A bug rust-lang/rust-bindgen#1627 causes compilation failure in nightly compiler.
danieldulaney pushed a commit to danieldulaney/rust-ffmpeg-sys that referenced this pull request Nov 30, 2019
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
meh pushed a commit to meh/rust-ffmpeg-sys that referenced this pull request Dec 5, 2019
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
bacek pushed a commit to bacek/rust-ffmpeg4-sys that referenced this pull request Feb 29, 2020
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
tilpner pushed a commit to tilpner/rust-ffmpeg that referenced this pull request Apr 26, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
tilpner pushed a commit to tilpner/rust-ffmpeg that referenced this pull request Apr 26, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
tilpner pushed a commit to tilpner/rust-ffmpeg that referenced this pull request May 24, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
tilpner pushed a commit to meh/rust-ffmpeg that referenced this pull request May 24, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see
rust-lang/rust-bindgen#1627), so an upgrade is
needed.

However, the new version also breaks when enum values are also defined as
macros. Previously, this could be handled with blacklist_type, but the
recommended method is by implementing will_parse_macro and returning
Ignore for problematic enum variants. This commit implements that method
and removes the old method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants