Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non_exhaustive rustified enums. #1575

Merged
merged 6 commits into from Jun 12, 2019
Merged

Add support for non_exhaustive rustified enums. #1575

merged 6 commits into from Jun 12, 2019

Conversation

agodnic
Copy link
Contributor

@agodnic agodnic commented Jun 10, 2019

Implements the feature discussed in #1554.

Implements the feature discussed in
#1554.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation-wise looks good! Mostly some requests about naming / API shape and the test needs to be fixed. But we can totally land features that work only on nightly, as long as it's reflected properly on the rust_target, so no need to wait for stabilization.

src/codegen/mod.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/headers/issue-1554.h Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, this looks good! Just a couple more nits and a test fix left.

Thank you!

src/codegen/mod.rs Outdated Show resolved Hide resolved
src/codegen/mod.rs Outdated Show resolved Hide resolved
src/codegen/mod.rs Outdated Show resolved Hide resolved
tests/headers/issue-1554.h Outdated Show resolved Hide resolved
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants