Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite with --release-channel=stable #11

Closed
tmandry opened this issue May 8, 2021 · 2 comments · Fixed by rust-lang/rust#86098
Closed

Run test suite with --release-channel=stable #11

tmandry opened this issue May 8, 2021 · 2 comments · Fixed by rust-lang/rust#86098

Comments

@tmandry
Copy link
Member

tmandry commented May 8, 2021

This will help us catch failures that occur when the channel is not nightly, like in rust-lang/rust#84950.

We could also run tests for beta, but there are diminishing returns there.

@pietroalbini
Copy link
Member

Opened a PR with the fix at rust-lang/rust#86098.

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 10, 2021
…lacrum

Add the x86_64-gnu-stable builder

During the 1.52 release process we had to deal with some commits that passed the test suite on the nightly branch but failed on the beta or stable branch. In that case it was due to some UI tests including the channel name in the output, but other changes might also be dependent on the channel.

This commit adds a new CI job that runs the Linux x86_64 test suite with the stable branch, ensuring nightly changes also work as stable. To ensure the new job works the following other changes are present:

* The `ui-fulldeps/session-derive-errors.rs` test has been disabled on beta and stable, which required adding support for `// ignore-{channel}` and `// only-{channel}`.
* The `rustdoc/intra-doc/field.rs` has been fixed.

r? `@Mark-Simulacrum`
fixes rust-lang/release-team#11
@Mark-Simulacrum
Copy link
Member

Closing -- we've done this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants