Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex-syntax fails to compile with unicode-perl feature #770

Closed
ThouCheese opened this issue May 1, 2021 · 3 comments · Fixed by #771
Closed

regex-syntax fails to compile with unicode-perl feature #770

ThouCheese opened this issue May 1, 2021 · 3 comments · Fixed by #771

Comments

@ThouCheese
Copy link

ThouCheese commented May 1, 2021

What version of regex are you using?

Regex 1.5.2, regex-syntax 0.6.24

Describe the bug at a high level.

regex-syntax doesn't compile when default features are turned off and unicode-perl is turned on.

What are the steps to reproduce the behavior?

Create a new cargo project and list either regex or regex-syntax with default-features turned off and unicode-perl turned on. Easy repro: clone this git repository: https://github.com/ThouCheese/regex-issue

What is the actual behavior?

I expect this to compile.

What is the expected behavior?

I doesn't compile with the error message:

    |
375 |         use unicode_tables::perl_decimal::DECIMAL_NUMBER;
    |             ^^^^^^^^^^^^^^ use of undeclared crate or module `unicode_tables`

This should be fixed if line 375 is changed to use crate::unicode_tables::perl_decimal::DECIMAL_NUMBER;, I believe.

@BurntSushi
Copy link
Member

Dupe of #769.

Thanks for reporting this though!

@BurntSushi
Copy link
Member

#771 is a PR in progress to fix this and fix CI so that these regressions actually failed the build.

@ThouCheese
Copy link
Author

Too slow! Thanks for the quick reply Andrew!

BurntSushi added a commit that referenced this issue May 1, 2021
When only the unicode-perl feature is enabled, regex-syntax would fail
to build. It turns out that 'cargo fix' doesn't actually fix all
imports. It looks like it only fixes things that it can build in the
current configuration.

Fixes #769, Fixes #770
BurntSushi added a commit that referenced this issue May 1, 2021
When only the unicode-perl feature is enabled, regex-syntax would fail
to build. It turns out that 'cargo fix' doesn't actually fix all
imports. It looks like it only fixes things that it can build in the
current configuration.

Fixes #769, Fixes #770
BurntSushi added a commit that referenced this issue May 1, 2021
When only the unicode-perl feature is enabled, regex-syntax would fail
to build. It turns out that 'cargo fix' doesn't actually fix all
imports. It looks like it only fixes things that it can build in the
current configuration.

Fixes #769, Fixes #770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants