Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross-compilation if pkg-config is customized #86

Merged
merged 1 commit into from Jul 25, 2019

Conversation

kornelski
Copy link
Contributor

Implements #41

  • if pkg-config appears to be customized for cross-compilation (sets PKG_CONFIG_SYSROOT_DIR or a wrapper script), then allow cross-compilation by default
  • PKG_CONFIG_ALLOW_CROSS=0 disables the heuristic and always forbids
  • uses targetted_env_var helper method, so it will also recognize per-target settings and correctly re-check if the env vars change.

@sdroege sdroege merged commit 69d261f into rust-lang:master Jul 25, 2019
@sdroege
Copy link
Collaborator

sdroege commented Jul 25, 2019

Thanks! This makes a lot of sense

@sdroege
Copy link
Collaborator

sdroege commented Jul 25, 2019

@alexcrichton Can you make a new release with this some time in the next days when get to it? Thanks :)

@alexcrichton
Copy link
Member

Oh oops sorry I thought you were already an owner on crates.io! I've invited you to the crate on crates.io now and I'll let you take care of the release if that's ok

@sdroege
Copy link
Collaborator

sdroege commented Jul 25, 2019

Sure, will do later. Thanks!

@kornelski kornelski deleted the autocross branch July 25, 2019 14:53
@sdroege
Copy link
Collaborator

sdroege commented Jul 25, 2019

Ok, 0.3.15 is released with this

src/lib.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants