Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying range of versions. #75

Merged
merged 8 commits into from Oct 16, 2018

Conversation

Hakuyume
Copy link
Contributor

@Hakuyume Hakuyume commented Oct 16, 2018

close #74

This PR adds two new methods: eq_version and range_version.

@Hakuyume Hakuyume mentioned this pull request Oct 16, 2018
Copy link
Collaborator

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks mostly good to me :)

src/lib.rs Outdated
}

/// Indicate that the library must be equal to version `vers`.
pub fn eq_version(&mut self, vers: &str) -> &mut Config {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe exactly_version()?

src/lib.rs Show resolved Hide resolved
tests/test.rs Outdated
fn range_version_range_ng() {
let _g = LOCK.lock();
reset();
pkg_config::Config::new().range_version("3.12".."3.15").probe("foo").unwrap();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add tests for inclusive vs. exclusive ranges

@sdroege
Copy link
Collaborator

sdroege commented Oct 16, 2018

Great, looks good to me. @alexcrichton, good for you too?

@alexcrichton alexcrichton merged commit 50b422e into rust-lang:master Oct 16, 2018
@alexcrichton
Copy link
Member

Indeed!

@Hakuyume Hakuyume deleted the version branch October 16, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exact_version
3 participants