New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying range of versions. #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks mostly good to me :)
src/lib.rs
Outdated
} | ||
|
||
/// Indicate that the library must be equal to version `vers`. | ||
pub fn eq_version(&mut self, vers: &str) -> &mut Config { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe exactly_version()
?
tests/test.rs
Outdated
fn range_version_range_ng() { | ||
let _g = LOCK.lock(); | ||
reset(); | ||
pkg_config::Config::new().range_version("3.12".."3.15").probe("foo").unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add tests for inclusive vs. exclusive ranges
Great, looks good to me. @alexcrichton, good for you too? |
Indeed! |
close #74
This PR adds two new methods:
eq_version
andrange_version
.