Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exact_version #74

Closed
Hakuyume opened this issue Oct 13, 2018 · 7 comments · Fixed by #75
Closed

Support exact_version #74

Hakuyume opened this issue Oct 13, 2018 · 7 comments · Fixed by #75

Comments

@Hakuyume
Copy link
Contributor

pkg-config provides name = version syntax to specify the exact version. It would be nice to add a wrapper for this functionality. Although pkg_config::probe_library("name = version") works, I think it is abuse.

@sdroege
Copy link
Collaborator

sdroege commented Oct 15, 2018

What API do you suggest for this? Something like Config::atleast_version(), a Config::exact_version()?

@sdroege
Copy link
Collaborator

sdroege commented Oct 15, 2018

Would in any case be easy to add, as well as a name >= version_min, name < version_max kind of check

@Hakuyume
Copy link
Contributor Author

I was thinking Config::exact_version(). Taking (min, max) is also ok.

@sdroege
Copy link
Collaborator

sdroege commented Oct 15, 2018

I was thinking of both. Do you want to try your luck adding this? Otherwise I'll add it somewhere on my list but it might take a while until I get to it

@Hakuyume
Copy link
Contributor Author

OK, I'll try.

@sdroege
Copy link
Collaborator

sdroege commented Oct 16, 2018

Awesome! If you get stuck somewhere and need help, feel free to ask here, or if you want me to take over :)

@Hakuyume
Copy link
Contributor Author

@sdroege I made a PR (#75). Could you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants