Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customized pkg-config is incomplete? #118

Closed
igorbernstein opened this issue Mar 4, 2021 · 1 comment · Fixed by #121
Closed

customized pkg-config is incomplete? #118

igorbernstein opened this issue Mar 4, 2021 · 1 comment · Fixed by #121

Comments

@igorbernstein
Copy link

igorbernstein commented Mar 4, 2021

Hi,

I'm fairly new to rust and cross compilation in general, so I apologize if I'm misunderstanding something. But it seems like #86 is incomplete. It seems like it checks if PKG_CONFIG_<triple> is set to enable cross compilation, but doesn't actually use the wrapper script defined by that env var when constructing the command:

pkg-config-rs/src/lib.rs

Lines 396 to 398 in 5432578

let exe = self
.env_var_os("PKG_CONFIG")
.unwrap_or_else(|| OsString::from("pkg-config"));

I believe that should be changed to:

            self.targetted_env_var("PKG_CONFIG")
@igorbernstein igorbernstein changed the title customized pig-config is incomplete? customized pkg-config is incomplete? Mar 4, 2021
@sdroege
Copy link
Collaborator

sdroege commented Sep 9, 2021

I think so too, thanks for checking! Do you want to provide a PR for this?

sfackler added a commit to sfackler/pkg-config-rs that referenced this issue Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants