Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarize segfaults on large .mm_profdata files #201

Closed
jyn514 opened this issue Dec 27, 2022 · 3 comments · Fixed by #202
Closed

summarize segfaults on large .mm_profdata files #201

jyn514 opened this issue Dec 27, 2022 · 3 comments · Fixed by #202

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 27, 2022

$ summarize summarize rustc_query_impl-0451821.mm_profdata 
Segmentation fault (core dumped)
(gdb) where
#0  0x000055555560a830 in prettytable::TableSlice::get_all_column_width ()
#1  0x000055555560ac6c in prettytable::TableSlice::print_tty ()
#2  0x0000555555596eae in summarize::main ()
#3  0x0000555555585e73 in std::sys_common::backtrace::__rust_begin_short_backtrace ()
#4  0x00005555555a9549 in _ZN3std2rt10lang_start28_$u7b$$u7b$closure$u7d$$u7d$17h8cd4f4bd161a785dE.llvm.11794847080403208026 ()

This is because of phsym/prettytable-rs#146, I switched measureme to use that fork locally and it fixed the issue.

@jyn514
Copy link
Member Author

jyn514 commented Dec 27, 2022

We might also want to consider switching to a new library if that PR doesn't get merged reasonably soon; https://crates.io/crates/tabled looks reasonable.

@pinkforest
Copy link
Contributor

PR's up #202 with the fix in-release

@jyn514
Copy link
Member Author

jyn514 commented Dec 27, 2022

Thank you! I didn't expect you to reply so soon, I really appreciate it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants