Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with and document policy for adding new event kinds #106

Open
michaelwoerister opened this issue Jan 9, 2020 · 0 comments
Open

Comments

@michaelwoerister
Copy link
Member

Right now we have a few event kinds, basically the ones defined in https://github.com/rust-lang/measureme/blob/e6f55c7bcacc1c70b895c858d1840958709b9a34/measureme/src/rustc.rs.

If there is an event that is not recognized some tools will print out a warnings (e.g. summarize). Others might just ignore them.

I think we should document somewhere:

  • How to add new event kinds
  • What kind of support is expected for each kind of event (e.g. that all tools should be able to handle all known event kinds gracefully)
  • How to get approval for adding new events

I think that in general that it should be easy to add new event kinds (implementation-wise) but there should be a thorough review if it's really necessary to have a new event kind or if an existing event kind can be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant