New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check std feature against kv_unstable #434
Conversation
Check a few more permutations of `kv_unstable` features
It looks like this slipped through because the feature mismatch was masked by dev dependencies. |
Thanks a lot for the quick fix! I was just investigating why |
Once CI goes through I'll publish a |
Thanks so much - another |
Thinking about it - in case you believe this could possibly happen again, then |
It's definitely something worth looking into! We do something like this over in |
Even though I don't truly follow 😅 I would like to point out that the tool can be configured with options to handle special cases better. It seems this feature was entirely contributed, so I would hope that other needs that |
Ah great I'll take a look! If |
So that downloading uncompressed binary can be faster for slow connection. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Closes #433
There's an incorrect
#[cfg(feature = "std")]
inkv::value
that's broken users upgrading to0.4.12
. This PR fixes that up and runs a few more permutations in CI.