-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider rustfmt #182
Comments
I agree with using rustfmt. I generally disagree with requiring rustfmt for a build to pass. The tradeoff is scaring away new contributors. If someone makes a PR, I would prefer that they remember it as a reasonable discussion about meaningful things, rather than as a struggle to satisfy a grumpy buildbot. If the code looks mostly fine then nobody will notice or care anyway. Somebody can run rustfmt every month or so and it takes 10 seconds to clean everything up, so there isn't really anything to gain from enforcing it in the build. |
Well your take was more accurate to what I intended. |
Moved from #150 (comment):
The text was updated successfully, but these errors were encountered: