Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rustfmt #182

Closed
dtolnay opened this issue May 29, 2017 · 2 comments
Closed

Consider rustfmt #182

dtolnay opened this issue May 29, 2017 · 2 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented May 29, 2017

Moved from #150 (comment):

Could we make rust fmt mandatory for this crate ?

@dtolnay
Copy link
Member Author

dtolnay commented May 29, 2017

I agree with using rustfmt.

I generally disagree with requiring rustfmt for a build to pass. The tradeoff is scaring away new contributors. If someone makes a PR, I would prefer that they remember it as a reasonable discussion about meaningful things, rather than as a struggle to satisfy a grumpy buildbot. If the code looks mostly fine then nobody will notice or care anyway. Somebody can run rustfmt every month or so and it takes 10 seconds to clean everything up, so there isn't really anything to gain from enforcing it in the build.

@meven
Copy link
Contributor

meven commented May 29, 2017

Well your take was more accurate to what I intended.
My idea was in fact to find a way to ensure the code was formated.
I use rustfmt regularly and when I used it on this crate in a branch, it touched a lot of lines that did not need to be formated and made my commit noisy.
I feel your idea of behind the scene occasional formating a better solution.

@dtolnay dtolnay mentioned this issue May 30, 2017
EFanZh pushed a commit to EFanZh/log that referenced this issue Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants