Make log target configurable #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `env_logger` always logs to stderr. This might be undesireable in some cases. This commit adds a way to configure the log target. It can be set to stdout if desired. Note that writing to stdout is implemented with `println!` instead of `writeln!`, so that the output is properly captured in tests.
|
@alexcrichton @sfackler any chance that someone could take a look at this? It would considerably improve Cargo test output (since right now all test output is intermingled with log messages that aren't properly captured). The change should be quick to review, only around 20 lines of code. |
sfackler
reviewed
Apr 7, 2017
| @@ -337,7 +356,12 @@ impl Log for Logger { | |||
| } | |||
| } | |||
|
|
|||
| let _ = writeln!(&mut io::stderr(), "{}", (self.format)(record)); | |||
| match self.target { | |||
| LogTarget::Stdout => println!("{}", (self.format)(record)), | |||
There was a problem hiding this comment.
Should this be a writeln! to io::stdout instead? There are some differences around capture in the test harness. Not sure which approach would be more expected.
There was a problem hiding this comment.
writeln! with io::stdout is not being captured by the test harness according to my tests.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
env_loggeralways logs to stderr. This might be undesireable in some cases.This PR adds a way to configure the log target. It can be set to stdout if desired.
Note that writing to stdout is implemented with
println!instead ofwriteln!, so that the output is properly captured in tests. See https://users.rust-lang.org/t/cargo-doesnt-capture-stderr-of-running-tests/9222/.I did not find out how to properly add a test, but tested it manually. If you want a test to be added, pointers would be welcome.