Use smaller IPIO2 table for 16 and 32 bit architectures #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we should probably use the short table everywhere. However we may end up adding f128 in the future, so it's good to still have the code in there. |
waynevanson
added a commit
to waynevanson/veml6030-rs
that referenced
this pull request
May 10, 2023
This commit contains PR from rust-lang/libm#266
waynevanson
added a commit
to waynevanson/veml6030-rs
that referenced
this pull request
May 10, 2023
This commit contains PR from rust-lang/libm#266
waynevanson
added a commit
to waynevanson/veml6030-rs
that referenced
this pull request
May 10, 2023
This commit contains PR from rust-lang/libm#266
waynevanson
added a commit
to waynevanson/veml6030-rs
that referenced
this pull request
May 10, 2023
This commit contains PR from rust-lang/libm#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
All tests pass after change. The longer version of the table is only needed for 128 bit floats, which this lib doesn't support. The short table could be used on all architectures, honestly