Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solarish amd64 regset constants #2930

Merged
merged 1 commit into from Oct 6, 2022

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Some changes occurred in solarish module

cc @jclulow,@pfmooney

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

LGTM, @jclulow @pfmooney could you review when you have some time?

@pfmooney
Copy link
Contributor

pfmooney commented Oct 4, 2022

I think it looks OK, but I have one question (directed to @devnexen):

Are there existing or potential consumers which are driving these additions? There have been bits added in the past -- MR_HDR_AOUT is the most recent example -- an effectively Uncommitted interfaces which, when cleaned up caused the libc-test suite to start failing on new machines.

I'm happy to see additions if they will (or are likely to) be used, and are not exposing bits of the OS which are less than Committed.

Thanks

@devnexen
Copy link
Contributor Author

devnexen commented Oct 4, 2022

This particular set is indeed used within a getcontext part, it would be more readable using these constants.

@JohnTitor
Copy link
Member

I'm happy to see additions if they will (or are likely to) be used

This particular set is indeed used within a getcontext part, it would be more readable using these constants.

I'm going to r+ considering this is approved with the above.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2022

📌 Commit 9178f55 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 6, 2022

⌛ Testing commit 9178f55 with merge 2dfe1ab...

@bors
Copy link
Contributor

bors commented Oct 6, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 2dfe1ab to master...

@bors bors merged commit 2dfe1ab into rust-lang:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants