Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Linux system call constants #2904

Merged
merged 2 commits into from Sep 12, 2022
Merged

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Sep 9, 2022

This adds the latest Linux system call constants based on the Kernel's system call table:

https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl

This adds the latest Linux system call constants based on the Kernel's
system call table:

https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@cd-work
Copy link
Contributor Author

cd-work commented Sep 9, 2022

I have no idea how the process for adding new system call constants generally works, but I saw that #2114 seemingly just added all the stuff manually and decided to do the same.

I personally need the landlock system calls, so that's my motivation for the PR. So I thought I might as well upstream these changes.

I've only checked the system call table for x86_64 and extrapolated all the other architectures from there. It seems like for existing syscalls they're mostly the same with some constant offset, so I've tried to just keep that pattern going.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're sure they are valid on each arch and aren't supposed to be changed in the long term, I think it's totally fine.
Thanks for contributing!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2022

📌 Commit 5f5d0de has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Sep 11, 2022
Add new Linux system call constants

This adds the latest Linux system call constants based on the Kernel's system call table:

https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscall_64.tbl
@bors
Copy link
Contributor

bors commented Sep 11, 2022

⌛ Testing commit 5f5d0de with merge 276ae06...

@bors
Copy link
Contributor

bors commented Sep 11, 2022

💔 Test failed - checks-actions

@cd-work
Copy link
Contributor Author

cd-work commented Sep 12, 2022

The build failed on a component download on Windows, so I don't think it's related to this PR.

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Sep 12, 2022

⌛ Testing commit 5f5d0de with merge a74954e...

@bors
Copy link
Contributor

bors commented Sep 12, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing a74954e to master...

@bors bors merged commit a74954e into rust-lang:master Sep 12, 2022
@cd-work cd-work deleted the linux_syscalls branch September 13, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants