Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple: Add the attrlist set of functions #2902

Merged
merged 1 commit into from Sep 9, 2022

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Sep 6, 2022

Add the attrlist set of functions for apple platforms.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit c77ee00 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 9, 2022

⌛ Testing commit c77ee00 with merge fb16d18...

@bors
Copy link
Contributor

bors commented Sep 9, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing fb16d18 to master...

@bors bors merged commit fb16d18 into rust-lang:master Sep 9, 2022
bors added a commit that referenced this pull request Sep 19, 2022
Bump version to 0.2.133

Bump version to 0.2.133 to allow using #2902 from crates.io.

pub fn getattrlist(
path: *const ::c_char,
attrList: *mut ::c_void,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the man page, I think the attrList parameters for these functions should be *mut attrlist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I recall, I originally did that, but it turns out the man page doesn't match the headers and so I had to change it to make the tests pass.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, does look like the header has it declared as void *. Womp. Oh well, just means I need an extra ptr.cast().

@beetrees beetrees deleted the apple-attrlist branch March 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants