New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apple: Add the attrlist set of functions #2902
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
544e9ae
to
6ec7c79
Compare
6ec7c79
to
c77ee00
Compare
Thanks! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Bump version to 0.2.133 Bump version to 0.2.133 to allow using #2902 from crates.io.
|
||
pub fn getattrlist( | ||
path: *const ::c_char, | ||
attrList: *mut ::c_void, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the man page, I think the attrList
parameters for these functions should be *mut attrlist
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I recall, I originally did that, but it turns out the man page doesn't match the headers and so I had to change it to make the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, does look like the header has it declared as void *
. Womp. Oh well, just means I need an extra ptr.cast()
.
Add the attrlist set of functions for apple platforms.