Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing SOF_TIMESTAMPING flags #2881

Merged
merged 3 commits into from Aug 27, 2022

Conversation

folkertdev
Copy link
Contributor

These flags are useful for send (tx) timestamping in practice, and used by @tweedegolf's work on PTP and NTP

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@folkertdev
Copy link
Contributor Author

I must be missing something about the test setup here. Does anyone know why the CI build fails?

pub const SOF_TIMESTAMPING_OPT_STATS: ::c_uint = 1 << 12;
pub const SOF_TIMESTAMPING_OPT_PKTINFO: ::c_uint = 1 << 13;
pub const SOF_TIMESTAMPING_OPT_TX_SWHW: ::c_uint = 1 << 14;
pub const SOF_TIMESTAMPING_BIND_PHC: ::c_uint = 1 << 15;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOF_TIMESTAMPING_BIND_PHC is newly added and our CI doesn't know it: torvalds/linux@d463126

We could skip the test for it.

@folkertdev
Copy link
Contributor Author

@JohnTitor I removed the BIND_PHC flag from this PR. it is used in PTP rather than NTP and so it's likely it depends on kernel feature flags. I also don't need it specifically. So I'm happy with this PR as-is

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2022

📌 Commit 075ca11 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 26, 2022

⌛ Testing commit 075ca11 with merge c419a54...

bors added a commit that referenced this pull request Aug 26, 2022
…Titor

add missing SOF_TIMESTAMPING flags

These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
@bors
Copy link
Contributor

bors commented Aug 26, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Aug 26, 2022

⌛ Testing commit 075ca11 with merge f2e97e2...

bors added a commit that referenced this pull request Aug 26, 2022
…Titor

add missing SOF_TIMESTAMPING flags

These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
@bors
Copy link
Contributor

bors commented Aug 26, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

bors added a commit that referenced this pull request Aug 26, 2022
…Titor

add missing SOF_TIMESTAMPING flags

These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
@bors
Copy link
Contributor

bors commented Aug 26, 2022

⌛ Testing commit 075ca11 with merge 6413f0c...

@bors
Copy link
Contributor

bors commented Aug 26, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Aug 27, 2022

⌛ Testing commit 075ca11 with merge a5553c2...

@bors
Copy link
Contributor

bors commented Aug 27, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing a5553c2 to master...

@bors bors merged commit a5553c2 into rust-lang:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants