New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing SOF_TIMESTAMPING flags #2881
add missing SOF_TIMESTAMPING flags #2881
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
I must be missing something about the test setup here. Does anyone know why the CI build fails? |
src/unix/linux_like/linux/mod.rs
Outdated
pub const SOF_TIMESTAMPING_OPT_STATS: ::c_uint = 1 << 12; | ||
pub const SOF_TIMESTAMPING_OPT_PKTINFO: ::c_uint = 1 << 13; | ||
pub const SOF_TIMESTAMPING_OPT_TX_SWHW: ::c_uint = 1 << 14; | ||
pub const SOF_TIMESTAMPING_BIND_PHC: ::c_uint = 1 << 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOF_TIMESTAMPING_BIND_PHC
is newly added and our CI doesn't know it: torvalds/linux@d463126
We could skip the test for it.
@JohnTitor I removed the |
Thanks! @bors r+ |
…Titor add missing SOF_TIMESTAMPING flags These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
💔 Test failed - checks-actions |
@bors retry |
…Titor add missing SOF_TIMESTAMPING flags These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
💔 Test failed - checks-actions |
@bors retry |
…Titor add missing SOF_TIMESTAMPING flags These flags are useful for send (tx) timestamping in practice, and used by `@tweedegolf's` work on PTP and NTP
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
These flags are useful for send (tx) timestamping in practice, and used by @tweedegolf's work on PTP and NTP