Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions in libc headers in Android for riscv64 #2857

Merged
merged 1 commit into from Aug 9, 2022

Conversation

MaoHan001
Copy link

Signed-off-by: Chen Guoyin chenguoyin.cgy@linux.alibaba.com
Signed-off-by: Mao Han han_mao@linux.alibaba.com

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@Amanieu
Copy link
Member

Amanieu commented Aug 3, 2022

Style check is failing, can you run cargo fmt?

Signed-off-by: Chen Guoyin <chenguoyin.cgy@linux.alibaba.com>
Signed-off-by: Mao Han <han_mao@linux.alibaba.com>
@MaoHan001
Copy link
Author

Style check is failing, can you run cargo fmt?

Style check fixed

@Amanieu
Copy link
Member

Amanieu commented Aug 9, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2022

📌 Commit 18cfed6 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 9, 2022

⌛ Testing commit 18cfed6 with merge 424e7e3...

@Amanieu
Copy link
Member

Amanieu commented Aug 9, 2022

@joshtriplett Note that this PR adds an align.rs, you'll want to undo this in your PR.

@bors
Copy link
Contributor

bors commented Aug 9, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: Amanieu
Pushing 424e7e3 to master...

@bors bors merged commit 424e7e3 into rust-lang:master Aug 9, 2022
@MaoHan001
Copy link
Author

@joshtriplett Note that this PR adds an align.rs, you'll want to undo this in your PR.

need another PR to remove this file?

@Amanieu
Copy link
Member

Amanieu commented Aug 11, 2022

No, this needs to be done in #2845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants