linux musl adding PIDFD_NONBLOCK constant.
#3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
|
Could you add them to https://github.com/rust-lang/libc/blob/master/libc-test/semver/linux-musl.txt? |
devnexen
force-pushed
the
musl_pidfd_nonblock
branch
from
515a816
to
b9dbd5e
Compare
JohnTitor
approved these changes
Nov 20, 2022
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Nov 20, 2022
linux musl adding `PIDFD_NONBLOCK` constant. closes #3002
|
💔 Test failed - checks-actions |
JohnTitor
reviewed
Nov 20, 2022
| @@ -590,6 +590,9 @@ pub const EFD_NONBLOCK: ::c_int = ::O_NONBLOCK; | |||
|
|
|||
| pub const SFD_NONBLOCK: ::c_int = ::O_NONBLOCK; | |||
|
|
|||
| pub const SOCK_NONBLOCK: ::c_int = O_NONBLOCK; | |||
There was a problem hiding this comment.
Seems we already have SOCK_NONBLOCK
devnexen
force-pushed
the
musl_pidfd_nonblock
branch
from
b9dbd5e
to
7ba33fd
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Nov 20, 2022
linux musl adding `PIDFD_NONBLOCK` constant. closes #3002
|
💔 Test failed - checks-actions |
devnexen
force-pushed
the
musl_pidfd_nonblock
branch
from
7ba33fd
to
0993260
Compare
|
@bors r+ |
1 similar comment
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3002