illumos: Remove obsolete (and private) a.out define

[pfmooney]

This cleans up an obsolete definition which has been removed in upstream illumos, and thus is causing libc-test to fail on up-to-date machines.

[rust-highfive]

Some changes occurred in solarish module

cc @jclulow,@pfmooney

[rust-highfive]

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

[JohnTitor]

Could you deprecate it first instead of deleting directly? See https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy for the reason.

[pfmooney]

Could you deprecate it first instead of deleting directly? See https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy for the reason.

I can, if you insist.

This was part of a Private (not documented and subject to change/removal at any time) OS interface which probably should not have been added to rust-libc in the first place. As noted in the ticket for removing a.out exec functionality, support was limited to SPARC (which itself is deprecated on illumos). AFAIK, no work has been done to support Rust on illumos on SPARC.

All that said, I'll defer to what you think best.

Thanks.

[JohnTitor]

Thanks for clarifying! So, hmm, I guess we could assume there's no real user (or misunderstanding use) then. Given that, it seems okay to accept as-is. @bors r+

[bors]

📌 Commit bb88154 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit bb88154 with merge 71b864d...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 71b864d to master...