New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing STATX_ATTR_* constants on gnu/linux #2941
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Could you add them to https://github.com/rust-lang/libc/blob/master/libc-test/semver/linux-gnu.txt? |
1d7a4d6
to
93383c5
Compare
Sure thing! Done |
Thanks! @bors r+ |
…itor add missing STATX_ATTR_* constants on gnu/linux Corresponds to [this](https://github.com/torvalds/linux/blob/master/include/uapi/linux/stat.h#L189~L191): ```c #define STATX_ATTR_MOUNT_ROOT 0x00002000 /* Root of a mount */ #define STATX_ATTR_VERITY 0x00100000 /* [I] Verity protected file */ #define STATX_ATTR_DAX 0x00200000 /* File is currently in DAX state */ ```
💔 Test failed - checks-actions |
Docker Linux Tier2 (sparc64-unknown-linux-gnu) failed:
Honestly and sadly, I have no idea why these constants are not found on it |
Because SPARC64 image on CI is old and doesn't know them: libc/ci/docker/sparc64-unknown-linux-gnu/Dockerfile Lines 1 to 2 in a0ff4d2
You could ignore them on SPARC64 for now. |
Thanks for showing me this. Then let's wait for a glibc update on sparc64. |
I don't think we have to wait as it's just our CI issue. And these should be the same as on other archs, right? Then ignoring test for SPARC64 won't make a major issue here. |
93383c5
to
a8c85b4
Compare
Yes. I am sorry that I misunderstand you at first. Added them to |
@bors r+ |
…itor add missing STATX_ATTR_* constants on gnu/linux Corresponds to [this](https://github.com/torvalds/linux/blob/master/include/uapi/linux/stat.h#L189~L191): ```c #define STATX_ATTR_MOUNT_ROOT 0x00002000 /* Root of a mount */ #define STATX_ATTR_VERITY 0x00100000 /* [I] Verity protected file */ #define STATX_ATTR_DAX 0x00200000 /* File is currently in DAX state */ ```
💔 Test failed - checks-actions |
Timeout, @bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Corresponds to this: