Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ::Option and not Option for pthread_jit_write_callback_t #2931

Merged
merged 1 commit into from Sep 29, 2022

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Sep 29, 2022

The pthread_jit_write_callback_t type alias (introduced by #2896) uses Option rather than ::Option, which causes problems when trying to update the libc dependency that std has.

(Please cut a release after merging this <3)

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Sep 29, 2022

📌 Commit 1d7029a has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

⌛ Testing commit 1d7029a with merge e507572...

@bors
Copy link
Contributor

bors commented Sep 29, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing e507572 to master...

@bors bors merged commit e507572 into rust-lang:master Sep 29, 2022
@JohnTitor
Copy link
Member

@thomcc 0.2.134 is now available including this: https://crates.io/crates/libc/0.2.134

@thomcc
Copy link
Member Author

thomcc commented Sep 29, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants