Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU_SETSIZE constant to dragonflybsd. #2925

Merged
merged 1 commit into from Sep 28, 2022
Merged

CPU_SETSIZE constant to dragonflybsd. #2925

merged 1 commit into from Sep 28, 2022

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Seems it doesn't belong to cpuset.h but cpumask.h on DragonflyBSD: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/c163a4d7ee9c6857ee4e04a3a2cbb50c3de29da1/sys/sys/cpumask.h#L36

Looking at its declaration, it can be different from FreeBSD, I guess?

@devnexen
Copy link
Contributor Author

Seems it doesn't belong to cpuset.h but cpumask.h on DragonflyBSD: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/c163a4d7ee9c6857ee4e04a3a2cbb50c3de29da1/sys/sys/cpumask.h#L36

Looking at its declaration, it can be different from FreeBSD, I guess?

I did a quick c test and there is only one arch.

@JohnTitor
Copy link
Member

I mean, FreeBSD defines it as a fixed value but Dragonfly does it as a flexible value, so it's possible that these values would be different in the future. Following Dragonfly's manner is safer and I don't see any harm in it.

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit 5dc92a1 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2022

⌛ Testing commit 5dc92a1 with merge 6c91229...

@bors
Copy link
Contributor

bors commented Sep 28, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 6c91229 to master...

@bors bors merged commit 6c91229 into rust-lang:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devnexen @rust-highfive @JohnTitor @bors @Amanieu