Few socket updates related for Linux. #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
devnexen
force-pushed
the
socket_linux_update
branch
from
9f31ca3
to
cfb7e8b
Compare
JohnTitor
approved these changes
Jul 21, 2022
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jul 21, 2022
Few socket updates related for Linux.
|
💔 Test failed - checks-actions |
|
Seems emscripten doesn't have them. |
devnexen
force-pushed
the
socket_linux_update
branch
from
cfb7e8b
to
317b100
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jul 21, 2022
Few socket updates related for Linux.
|
💔 Test failed - checks-actions |
|
...Also Android doesn't have |
devnexen
force-pushed
the
socket_linux_update
branch
2 times, most recently
from
f6da550
to
421c0ff
Compare
JohnTitor
reviewed
Jul 22, 2022
src/unix/linux_like/mod.rs
Outdated
| @@ -775,6 +775,11 @@ pub const MSG_ERRQUEUE: ::c_int = 0x2000; | |||
| pub const MSG_NOSIGNAL: ::c_int = 0x4000; | |||
| pub const MSG_MORE: ::c_int = 0x8000; | |||
| pub const MSG_WAITFORONE: ::c_int = 0x10000; | |||
| cfg_if! { | |||
| if #[cfg(not(all(target_os = "emscripten", target_os = "android")))] { | |||
There was a problem hiding this comment.
Could you just move them to src/unix/linux_like/linux/mod.rs to avoid cfg complexity?
devnexen
force-pushed
the
socket_linux_update
branch
from
421c0ff
to
2b05c86
Compare
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.