Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv32 support for musl C library based linux platforms #2540

Merged
merged 1 commit into from Apr 29, 2022

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Nov 16, 2021

Signed-off-by: Khem Raj raj.khem@gmail.com

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@kanavin
Copy link

kanavin commented Nov 17, 2021

ci/build.sh needs to be adjusted, so this is tested properly, as seen here:
cb585ff

@kraj
Copy link
Contributor Author

kraj commented Nov 17, 2021

ci/build.sh needs to be adjusted, so this is tested properly, as seen here: cb585ff

musl/rv32 support is still in upstreaming process. Once thats done, we will add it to CI

@kanavin
Copy link

kanavin commented Nov 17, 2021

ci/build.sh needs to be adjusted, so this is tested properly, as seen here: cb585ff

musl/rv32 support is still in upstreaming process. Once thats done, we will add it to CI

Can you link to the merge request please then? I thought the below was enough, is there some other in-progress activity somewhere?
rust-lang/rust#82202

@Amanieu
Copy link
Member

Amanieu commented Apr 28, 2022

Style check is failing, can you please fix it?

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj
Copy link
Contributor Author

kraj commented Apr 28, 2022

Style check is failing, can you please fix it?

fixed

@Amanieu
Copy link
Member

Amanieu commented Apr 29, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2022

📌 Commit 391a9b2 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Apr 29, 2022

⌛ Testing commit 391a9b2 with merge a31c793...

@bors
Copy link
Contributor

bors commented Apr 29, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing a31c793 to master...

@bors bors merged commit a31c793 into rust-lang:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants