Add strtof for all platforms that have strtod
#2358
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All platforms that have `strtod` very likely also have `strtof`. Having `strtof` allows for fuzzing of `hexf-parse::parse_hexf32` comparing against `strtof`, which can't (easily) be done with `strtod`, due to float rounding and over-/underflow behavior.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
JohnTitor
approved these changes
Aug 24, 2021
|
Looks good, thanks! |
|
📌 Commit f0dd7a9 has been approved by |
|
Should I open a version bump PR after this or is one upcoming already? I'd like to use |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Merged
bors
added a commit
that referenced
this pull request
Aug 25, 2021
Bump to 0.2.101 New release to allow for usage of `strtof` introduced in #2358 for fuzzing of `hexf-parse` while comparing against `strtof` results.
bors
added a commit
that referenced
this pull request
Aug 25, 2021
Bump to 0.2.101 New release to allow for usage of `strtof` introduced in #2358 for fuzzing of `hexf-parse` while comparing against `strtof` results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All platforms that have
strtodvery likely also havestrtof. Havingstrtofallows for fuzzing ofhexf-parse::parse_hexf32comparing againststrtof, which can't (easily) be done withstrtod, due to float rounding and over-/underflow behavior.I'm unsure of whether the
strtofdeclaration insrc/unix/mod.rsalso needs a link name adjustment for x86 macos. I haven't been able to find anything about this after a rough search in this repo and on Google. I haven't added it for now since onlystrtod(edit: out of thestrtoXfunctions) seems to have the changed link name (and I don't have a mac handy to test the available symbols with), but feel free to tell me if it's needed and I'll adjust the PR accordingly.