Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos clonefile functions #2147

Merged
merged 1 commit into from Apr 18, 2021
Merged

Add macos clonefile functions #2147

merged 1 commit into from Apr 18, 2021

Conversation

nthery
Copy link
Contributor

@nthery nthery commented Apr 17, 2021

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nthery nthery mentioned this pull request Apr 17, 2021
Closed
@JohnTitor
Copy link
Member

Could you squash commits into one?

@nthery
Copy link
Contributor Author

nthery commented Apr 17, 2021

Could you squash commits into one?

Done. Thanks.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2021

📌 Commit c8539f5 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Apr 17, 2021

⌛ Testing commit c8539f5 with merge 6570c66...

@bors
Copy link
Contributor

bors commented Apr 18, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 6570c66 to master...

@bors bors merged commit 6570c66 into rust-lang:master Apr 18, 2021
@nthery nthery deleted the clonefile branch April 18, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nthery @rust-highfive @JohnTitor @bors @Amanieu