Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port_notify struct for illumos and Solaris #2042

Merged
merged 1 commit into from Jan 27, 2021

Conversation

pfmooney
Copy link
Contributor

This adds a missing struct for configuring event ports notifications. The libc-test suite passes on illumos (OmniOSCE) and is assumed to pass on Solaris, given that the interface has been present since Oracle forked from OpenSolaris.

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The libc-test suite passes on illumos (OmniOSCE) and is assumed to pass on Solaris, given that the interface has been present since Oracle forked from OpenSolaris.

👍, thanks for clarifying!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2021

📌 Commit 0d61dcb has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jan 27, 2021

⌛ Testing commit 0d61dcb with merge 77180b6...

@pfmooney
Copy link
Contributor Author

LGTM

The libc-test suite passes on illumos (OmniOSCE) and is assumed to pass on Solaris, given that the interface has been present since Oracle forked from OpenSolaris.

+1, thanks for clarifying!

Thank you!

@bors
Copy link
Contributor

bors commented Jan 27, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 77180b6 to master...

@bors bors merged commit 77180b6 into rust-lang:master Jan 27, 2021
@pfmooney pfmooney deleted the illumos-portnotify branch August 9, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants