Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the ILP32 variant of AArch64 #2039

Merged
merged 2 commits into from Jan 27, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jan 20, 2021

This also fixes mutex initializers on big-endian AArch64.

This commit also fixes mutex initializers on big-endian.
@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu Amanieu changed the title Add support for the ILP32 variant of AArch64Aarch64 ilp32 Add support for the ILP32 variant of AArch64 Jan 20, 2021
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this contains some breaking changes but I assume they currently doesn't work correctly.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2021

📌 Commit dc02daa has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jan 26, 2021

⌛ Testing commit dc02daa with merge 8208fed...

bors added a commit that referenced this pull request Jan 26, 2021
Add support for the ILP32 variant of AArch64

This also fixes mutex initializers on big-endian AArch64.
@bors
Copy link
Contributor

bors commented Jan 26, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

bors added a commit that referenced this pull request Jan 26, 2021
Add support for the ILP32 variant of AArch64

This also fixes mutex initializers on big-endian AArch64.
@bors
Copy link
Contributor

bors commented Jan 26, 2021

⌛ Testing commit dc02daa with merge c9afb87...

@bors
Copy link
Contributor

bors commented Jan 26, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member Author

Amanieu commented Jan 26, 2021

Failures seem to be unrelated to this PR.

@Amanieu
Copy link
Member Author

Amanieu commented Jan 27, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Jan 27, 2021

⌛ Testing commit dc02daa with merge 3e2f350...

@bors
Copy link
Contributor

bors commented Jan 27, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 3e2f350 to master...

@bors bors merged commit 3e2f350 into rust-lang:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants