Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c typedefs for the Sony PSP #1753

Merged
merged 1 commit into from May 7, 2020
Merged

Conversation

overdrivenpotato
Copy link
Contributor

This adds support for PSP targets to build important libraries like libpanic_unwind.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@overdrivenpotato
Copy link
Contributor Author

The CI failure seems to be spurious, given that this PR does not touch android:

+ ./sdk/tools/bin/avdmanager create+ grep -v =
 avd --name arm --package system-images;android-24;google_apis;armeabi-v7a
Error: Package path is not valid. Valid system image paths are:
null

@JohnTitor
Copy link
Member

The failure should be fixed by #1754, could you rebase?

@overdrivenpotato
Copy link
Contributor Author

Sure, just rebased

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to merge but it'd be great if we could add CI for this target like the Nintendo Switch, when you add more items or have time anyway.

@JohnTitor JohnTitor merged commit 23d73d5 into rust-lang:master May 7, 2020
@overdrivenpotato
Copy link
Contributor Author

Sure, I’ll give it a shot soon. Going to try and get a basic PSP target into rustc first.

Comment on lines +26 to +27
pub const INT_MIN: c_int = -2147483648;
pub const INT_MAX: c_int = 2147483647;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder those constants is needed as you can use c_int::MAX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants