Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RISC-V 64-bit GNU/Linux #1606

Merged
merged 3 commits into from Nov 28, 2019
Merged

Support for RISC-V 64-bit GNU/Linux #1606

merged 3 commits into from Nov 28, 2019

Conversation

msizanoen1
Copy link
Contributor

Add support for RISC-V 64-bit GNU/Linux.

Follow up to rust-lang/rust#66661.

r? @alexcrichton

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a build job for this target here to make sure that this at least compiles: https://github.com/rust-lang/libc/blob/master/ci/build.sh#L224

You might want to consider taking over #1416 as a follow up (no need to try to do any of that here).

Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors: r+

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 27, 2019

📌 Commit 112b7f9 has been approved by gnzlbg

@msizanoen1
Copy link
Contributor Author

The target specification is not in the latest nightly, only master - even when using rustup update --force.
It looks like we will have to wait for next nightly.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 28, 2019

📌 Commit a06978b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 28, 2019

⌛ Testing commit a06978b with merge 5130285...

bors added a commit that referenced this pull request Nov 28, 2019
Support for RISC-V 64-bit GNU/Linux

Add support for RISC-V 64-bit GNU/Linux.

Follow up to rust-lang/rust#66661.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Nov 28, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 5130285 to master...

@bors bors merged commit a06978b into rust-lang:master Nov 28, 2019
@msizanoen1 msizanoen1 deleted the riscv branch November 28, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants