Add ucred and socket related types to uclibc-mips32

[zvirja]

Fix compilation of the tokio rust for MIPS architecture when using uClibc. Added missed types, which are defined in library headers:
https://github.com/kraj/uClibc/blob/ca1c74d67dd115d059a875150e10b8560a9c35a8/libc/sysdeps/linux/common/bits/socket.h#L320
https://github.com/kraj/uClibc/blob/ca1c74d67dd115d059a875150e10b8560a9c35a8/libc/sysdeps/linux/common/bits/in.h#L35-L36
https://github.com/kraj/uClibc/blob/ca1c74d67dd115d059a875150e10b8560a9c35a8/libc/sysdeps/linux/common/bits/in.h#L140-L143

Should also solve deprecrated/net2-rs#88

Revisit of #1500

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[zvirja]

All builds passed except two configurations:

• OSX I believe is not related to this PR at all 😟
• Nightly failed due to unused constants I introduced. I'm a bit confused by this one as constants are not meant to be necessarily used by the library itself - they are for the clients. Also there other unused constants around, but only mine ones got noticed 😕 Could you please advise on this one?

Thanks!

[gnzlbg]

@bors: r+

[bors]

📌 Commit b911a0e has been approved by gnzlbg

[bors]

⌛ Testing commit b911a0e with merge bc8aec2...

[bors]

💔 Test failed - status-azure

[zvirja]

Same results, but there is one spontaneous failure due to unavailable resources 😟

I'm happy to fix one with unused constants, could you please point me to right direction what to do?

[gnzlbg]

I'm happy to fix one with unused constants, could you please point me to right direction what to do?

Sure. Some of the constants that you added are "unused" which means that they are not exported by the library. This happens, for example, if a parent module e.g. .../mips/mod.rs already adds them, since these will shadow the ones that get imported from .../mips/mips32/mod.rs. So the best way to fix this is figure out if any of the parent modules exposes them, and if the values are correct, then just remove the ones that are duplicated. If the values are incorrect, then you need to move the constant from the parent module to the "upper" (more specific) modules for which they are correct.

[zvirja]

@gnzlbg Thanks for the hint! Those were indeed duplicated. Actually, after I made more precise look, I realized that the ucred type is common for all architectures and is not mips32 specific. So altered PR to define type on common layer and make everybody happy 😎

UPD: Finally build passed (except one with Mac, which is not PR related)

[gnzlbg]

@bors: r+

[bors]

📌 Commit 7335d1e has been approved by gnzlbg

[zvirja]

@bors: retry

[bors]

@zvirja: 🔑 Insufficient privileges: not in try users

[zvirja]

Fair enough, but worth trying ;-)

@gnzlbg It looks like it stuck and didn’t run tests again to merge the PR 🤔

[bors]

⌛ Testing commit 7335d1e with merge cfd561c...

[gnzlbg]

@zvirja there were other PRs in the queue, so bors couldn't start testing it immediately: https://buildbot2.rust-lang.org/homu/queue/libc

[bors]

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing cfd561c to master...

[zvirja]

@gnzlbg Thanks for your help and review! 🤝
Do you plan to make a new patch release in a nearby future? So I could consume the changes via crate? 😊

[gnzlbg]

There are a couple of PRs in the queue with good chances of merging as well. As soon as they merge in the next couple of hours I'll do a new release.