Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TIOCSBRK and TIOCCBRK #1587

Merged
merged 2 commits into from May 7, 2020
Merged

Add TIOCSBRK and TIOCCBRK #1587

merged 2 commits into from May 7, 2020

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Nov 7, 2019

No description provided.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@Susurrus
Copy link
Contributor Author

Susurrus commented Nov 8, 2019

Got a few errors on some platforms that just say "bash error XXX", so force-repushing to trigger a CI rerun. We'll see what happens.

@Susurrus
Copy link
Contributor Author

Susurrus commented Nov 8, 2019

Looks like fetching some packages is failing on some builds, not really certain why or if it's a temporary thing (I would assume so). I'll let it sit a couple of days and rerun again.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 18, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit 9c0772d has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 19, 2019

⌛ Testing commit 9c0772d with merge 506d2e7...

bors added a commit that referenced this pull request Nov 19, 2019
@bors
Auto merge of #1587 - Susurrus:termios_breaks_consts, r=gnzlbg
506d2e7 
Add TIOCSBRK and TIOCCBRK
@bors
Copy link
Contributor

bors commented Nov 19, 2019

💔 Test failed - status-azure

gnzlbg
gnzlbg suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sparc64-unknown-linux-gnu failure is legit.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

@Susurrus can you take a look at the failure?

@gnzlbg gnzlbg closed this Nov 28, 2019
@gnzlbg gnzlbg reopened this Nov 28, 2019
@Susurrus Susurrus force-pushed the termios_breaks_consts branch 3 times, most recently from 6915e9b to 0a4e073 Compare December 7, 2019 21:55
@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 7, 2019

Don't know why that last one failed; couldn't tell what the error was. Force repushed to trigger a new CI run.

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2019

So it's failing due to timing out, but the platforms that didn't get tested that last time were passing earlier so I think this is ready to merge, just needs some playing with CI flakiness.

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2019

So, I've force-pushed twice and I'm still getting the same CI time-out failures. Don't know what to do to push this forward.

@Susurrus
Copy link
Contributor Author

Anything I can do to keep this moving forward?

1 similar comment
@Susurrus
Copy link
Contributor Author

Anything I can do to keep this moving forward?

@gnzlbg
Copy link
Contributor

gnzlbg commented Dec 23, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit a459d0f has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Dec 23, 2019

⌛ Testing commit a459d0f with merge 6717fba...

bors added a commit that referenced this pull request Dec 23, 2019
@bors
Auto merge of #1587 - Susurrus:termios_breaks_consts, r=gnzlbg
6717fba 
Add TIOCSBRK and TIOCCBRK
@bors
Copy link
Contributor

bors commented Dec 23, 2019

💔 Test failed - status-azure

@Susurrus
Copy link
Contributor Author

Looks like it's still failing, but looks like a package is failing to install on one of the builds. However, it's been rerun several times now, and I think it's all been the same failure. Is this affecting other PRs or what can we do to resolve this?

@Susurrus
Copy link
Contributor Author

So now that i686-apple-darwin is not a Tier 1 target, that target fails in CI, but it's because the Rust installation fails, not due to this PR.

And BuildChannelsOSX nightly fails due to the armv7-apple-ios Rust target not being installed correctly. Is anyone actively working on resolving these failures? If not, is an appropriate fix to remove these targets, if so I can do that in this PR.

@bors
Copy link
Contributor

bors commented Apr 13, 2020

☔ The latest upstream changes (presumably #1719) made this pull request unmergeable. Please resolve the merge conflicts.

@Susurrus
Copy link
Contributor Author

Susurrus commented May 7, 2020

Only failing on arm-linux-androideabi with what looks to be an unrelated failure.

@JohnTitor
Copy link
Member

The failure should be fixed by #1754, could you rebase?

@Susurrus
Reorder consts for sparc64 to match header
d44f9b7
@Susurrus
Add TIOCSBRK/TIOCCBRK to more supported platforms
524ec8f 
Reorganized some constants as well so they're grouped a bit better.
@Susurrus
Copy link
Contributor Author

Susurrus commented May 7, 2020

CI finally passed!

@Susurrus Susurrus requested a review from gnzlbg May 7, 2020 21:01
JohnTitor
JohnTitor approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor JohnTitor merged commit cf63ea1 into rust-lang:master May 7, 2020
@bors bors mentioned this pull request May 7, 2020
Closed
@Susurrus Susurrus deleted the termios_breaks_consts branch May 8, 2020 15:14
@Susurrus Susurrus mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@gnzlbg gnzlbg Awaiting requested review from gnzlbg

Assignees

@gnzlbg gnzlbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Susurrus @rust-highfive @gnzlbg @bors @JohnTitor