Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement utmpx.h itens for NetBSD #1576

Merged
merged 7 commits into from Nov 28, 2019
Merged

Implement utmpx.h itens for NetBSD #1576

merged 7 commits into from Nov 28, 2019

Conversation

GrayJack
Copy link
Contributor

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@GrayJack GrayJack changed the title Implement utmpx.h itens Implement utmpx.h itens for NetBSD Nov 6, 2019
@GrayJack
Copy link
Contributor Author

GrayJack commented Nov 6, 2019

The fails seems not to be related my code changes

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 18, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit e8106bd has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 18, 2019

☔ The latest upstream changes (presumably #1586) made this pull request unmergeable. Please resolve the merge conflicts.

@GrayJack
Copy link
Contributor Author

@gnzlbg Do I have to resolve the merge comflicts or the moderators or libc that does that?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 19, 2019

Need to fix formatting.

@GrayJack
Copy link
Contributor Author

Looks like it was a error that cargo fmt didn't got

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 19, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 40f9253 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 19, 2019

⌛ Testing commit 40f9253 with merge 645fd1b...

bors added a commit that referenced this pull request Nov 19, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
645fd1b 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@GrayJack
Copy link
Contributor Author

Linux builds failed on CI, dunno why

@bors
Copy link
Contributor

bors commented Nov 19, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 20, 2019

error[E0277]: arrays only have std trait implementations for lengths 0..=32

You are trying to use PartialEq or Debug for arrays with more than 32 elements in your manual implementations, but these impls do not exist. You already are doing the "iterator workaround" for one of the fields, I think you just need to apply it to others.

@GrayJack
Copy link
Contributor Author

I did a cargo check --target x86_64-unknown-netbsd and now the check passed

@GrayJack
Copy link
Contributor Author

What failed?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 21, 2019

The network failed.

@bors: retry

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 21, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 21, 2019

📌 Commit 5d3c5b9 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 21, 2019

⌛ Testing commit 5d3c5b9 with merge a595c08...

bors added a commit that referenced this pull request Nov 21, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
a595c08 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@bors
Copy link
Contributor

bors commented Nov 21, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 21, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 21, 2019

⌛ Testing commit 5d3c5b9 with merge d11c858...

bors added a commit that referenced this pull request Nov 21, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
d11c858 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@bors
Copy link
Contributor

bors commented Nov 21, 2019

💔 Test failed - status-azure

@GrayJack
Copy link
Contributor Author

Can we test again?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit 5d3c5b9 with merge f7fca02...

bors added a commit that referenced this pull request Nov 27, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
f7fca02 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@bors
Copy link
Contributor

bors commented Nov 27, 2019

💔 Test failed - status-azure

@GrayJack
Copy link
Contributor Author

I don't known why macOS build fails

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2019

Looks spurious. @bors: r+

@bors
Copy link
Contributor

bors commented Nov 27, 2019

📌 Commit 6fffc16 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit 6fffc16 with merge 55f3283...

bors added a commit that referenced this pull request Nov 27, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
55f3283 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@bors
Copy link
Contributor

bors commented Nov 27, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

@bors: retry

bors added a commit that referenced this pull request Nov 28, 2019
@bors
Auto merge of #1576 - GrayJack:utmpx_netbsd, r=gnzlbg
51ae96a 
Implement utmpx.h itens for NetBSD

This PR partially closes #1534

If add the constants, structs and and extra traid implmentation
@bors
Copy link
Contributor

bors commented Nov 28, 2019

⌛ Testing commit 6fffc16 with merge 51ae96a...

@bors
Copy link
Contributor

bors commented Nov 28, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 51ae96a to master...

@bors bors merged commit 6fffc16 into rust-lang:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gnzlbg gnzlbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Request] Expose utmp and utmpx on netbsd
4 participants
@GrayJack @rust-highfive @gnzlbg @bors