Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move musl-compatible constants to linux/mod.rs #1462

Merged
merged 1 commit into from Aug 10, 2019

Conversation

jbaublitz
Copy link
Contributor

This is a continuation of #1452. I think CI is ready to run fully and the PR is ready to be merged if the pipelines pass based on the CI I've done using musl libc in my own projects.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@jbaublitz
Copy link
Contributor Author

I'm a little confused. I rebased onto master but the CI jobs in azure are either not visible in Github or the don't seem to have run even though I didn't disable anything. Is this expected?

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 10, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 10, 2019

📌 Commit 903a28b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Aug 10, 2019

⌛ Testing commit 903a28b with merge 692dc54...

bors added a commit that referenced this pull request Aug 10, 2019
Move musl-compatible constants to linux/mod.rs

This is a continuation of #1452. I think CI is ready to run fully and the PR is ready to be merged if the pipelines pass based on the CI I've done using musl libc in my own projects.
@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 10, 2019

I'm a little confused. I rebased onto master but the CI jobs in azure are either not visible in Github or the don't seem to have run even though I didn't disable anything. Is this expected?

It isn't, they aren't currently running for PRs, for some reason (but bors will run them). I need to investigate that.

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 10, 2019

@pietroalbini why can that be ?

trigger: ["auto-libc","try"]
pr: ["master"]

Shouldn't that trigger azure jobs in PR builds ? (e.g. see this other PR where only cirrus-ci is shown: #1461)

@bors
Copy link
Contributor

bors commented Aug 10, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 692dc54 to master...

@bors bors merged commit 903a28b into rust-lang:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants